Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 83b2c5d

Browse files
lrhnCommit Queue
authored and
Commit Queue
committed
Retire and remove 3.9 experiment flags.
Change-Id: I72262910b590f93ca5de7b3286c226d5ecaf3276 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443803 Reviewed-by: Johnni Winther <johnniwinther@google.com> Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Lasse Nielsen <lrn@google.com>
1 parent 82694c7 commit 83b2c5d

29 files changed

+25
-88
lines changed

‎pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ enum ExperimentalFlag {
109109
getterSetterError(
110110
name: 'getter-setter-error',
111111
isEnabledByDefault: true,
112-
isExpired: false,
112+
isExpired: true,
113113
experimentEnabledVersion: const Version(3, 9),
114114
experimentReleasedVersion: const Version(3, 9),
115115
),
@@ -181,7 +181,7 @@ enum ExperimentalFlag {
181181
nativeAssets(
182182
name: 'native-assets',
183183
isEnabledByDefault: true,
184-
isExpired: false,
184+
isExpired: true,
185185
experimentEnabledVersion: const Version(3, 9),
186186
experimentReleasedVersion: const Version(3, 9),
187187
),
@@ -205,7 +205,7 @@ enum ExperimentalFlag {
205205
nullAwareElements(
206206
name: 'null-aware-elements',
207207
isEnabledByDefault: true,
208-
isExpired: false,
208+
isExpired: true,
209209
experimentEnabledVersion: const Version(3, 8),
210210
experimentReleasedVersion: const Version(3, 8),
211211
),
@@ -253,7 +253,7 @@ enum ExperimentalFlag {
253253
soundFlowAnalysis(
254254
name: 'sound-flow-analysis',
255255
isEnabledByDefault: true,
256-
isExpired: false,
256+
isExpired: true,
257257
experimentEnabledVersion: const Version(3, 9),
258258
experimentReleasedVersion: const Version(3, 9),
259259
),

‎pkg/analyzer/lib/src/dart/analysis/experiments.g.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,7 @@ class IsExpired {
785785
static const bool generic_metadata = true;
786786

787787
/// Expiration status of the experiment "getter-setter-error"
788-
static const bool getter_setter_error = false;
788+
static const bool getter_setter_error = true;
789789

790790
/// Expiration status of the experiment "inference-update-1"
791791
static const bool inference_update_1 = true;
@@ -812,7 +812,7 @@ class IsExpired {
812812
static const bool named_arguments_anywhere = true;
813813

814814
/// Expiration status of the experiment "native-assets"
815-
static const bool native_assets = false;
815+
static const bool native_assets = true;
816816

817817
/// Expiration status of the experiment "non-nullable"
818818
static const bool non_nullable = true;
@@ -821,7 +821,7 @@ class IsExpired {
821821
static const bool nonfunction_type_aliases = true;
822822

823823
/// Expiration status of the experiment "null-aware-elements"
824-
static const bool null_aware_elements = false;
824+
static const bool null_aware_elements = true;
825825

826826
/// Expiration status of the experiment "patterns"
827827
static const bool patterns = true;
@@ -839,7 +839,7 @@ class IsExpired {
839839
static const bool set_literals = true;
840840

841841
/// Expiration status of the experiment "sound-flow-analysis"
842-
static const bool sound_flow_analysis = false;
842+
static const bool sound_flow_analysis = true;
843843

844844
/// Expiration status of the experiment "spread-collections"
845845
static const bool spread_collections = true;

‎pkg/dartdev/test/experiments_test.dart‎

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
import 'package:dartdev/src/experiments.dart';
6-
import 'package:dartdev/src/sdk.dart';
76
import 'package:test/test.dart';
87

8+
// ONLY use dedicated test experiments in this test.
9+
// Any other experiment will eventually be retired, and then a test depending
10+
// on it will fail.
11+
912
void main() {
1013
group('experiments', () {
1114
test('experimentalFeatures', () {
@@ -20,24 +23,5 @@ void main() {
2023
final errors = validateExperiments(['foo']);
2124
expect(errors, equals(['Unknown experiment: foo']));
2225
});
23-
24-
test('native assets experiment', () {
25-
final errors = validateExperiments(['native-assets']);
26-
final channel = Runtime.runtime.channel!;
27-
switch (channel) {
28-
case 'stable':
29-
case 'beta':
30-
expect(
31-
errors,
32-
equals([
33-
'Unavailable experiment: native-assets (this experiment is only '
34-
'available on the main, dev channels, this current channel is $channel)',
35-
]),
36-
);
37-
38-
default:
39-
expect(errors, isEmpty);
40-
}
41-
});
4226
});
4327
}

‎pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class ExperimentalFlag {
173173
static const ExperimentalFlag getterSetterError = const ExperimentalFlag(
174174
name: 'getter-setter-error',
175175
isEnabledByDefault: true,
176-
isExpired: false,
176+
isExpired: true,
177177
enabledVersion: const Version(3, 9),
178178
experimentEnabledVersion: const Version(3, 9),
179179
experimentReleasedVersion: const Version(3, 9),
@@ -254,7 +254,7 @@ class ExperimentalFlag {
254254
static const ExperimentalFlag nativeAssets = const ExperimentalFlag(
255255
name: 'native-assets',
256256
isEnabledByDefault: true,
257-
isExpired: false,
257+
isExpired: true,
258258
enabledVersion: const Version(3, 9),
259259
experimentEnabledVersion: const Version(3, 9),
260260
experimentReleasedVersion: const Version(3, 9),
@@ -281,7 +281,7 @@ class ExperimentalFlag {
281281
static const ExperimentalFlag nullAwareElements = const ExperimentalFlag(
282282
name: 'null-aware-elements',
283283
isEnabledByDefault: true,
284-
isExpired: false,
284+
isExpired: true,
285285
enabledVersion: const Version(3, 8),
286286
experimentEnabledVersion: const Version(3, 8),
287287
experimentReleasedVersion: const Version(3, 8),
@@ -335,7 +335,7 @@ class ExperimentalFlag {
335335
static const ExperimentalFlag soundFlowAnalysis = const ExperimentalFlag(
336336
name: 'sound-flow-analysis',
337337
isEnabledByDefault: true,
338-
isExpired: false,
338+
isExpired: true,
339339
enabledVersion: const Version(3, 9),
340340
experimentEnabledVersion: const Version(3, 9),
341341
experimentReleasedVersion: const Version(3, 9),
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +0,0 @@
1-
--enable-experiment=getter-setter-error

‎pkg/front_end/testcases/textual_outline.status‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,3 @@ regress/issue_34850: UnknownChunk # Test has parser errors
6363
coverage/external_test: FormatterCrash
6464
coverage/operator_unsupported_test: EmptyOutput
6565
coverage/syntax_get_set_syntax_test: UnknownChunk
66-
67-
null_aware_elements/constant_collections: FormatterCrash
68-
null_aware_elements/constant_null_aware_map_entry_shorting: FormatterCrash
69-
null_aware_elements/constant_null_aware_map_entry_shorting_erroneous: FormatterCrash
70-
null_aware_elements/simple_positive: FormatterCrash

‎tests/language/null_aware_elements/const_literals_error_test.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// SharedOptions=--enable-experiment=null-aware-elements
6-
75
import 'package:expect/expect.dart';
86

97
const nullConst = null;

‎tests/language/null_aware_elements/const_literals_test.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// SharedOptions=--enable-experiment=null-aware-elements
6-
75
import 'package:expect/expect.dart';
86

97
const nullConst = null;

‎tests/language/null_aware_elements/evaluation_order_test.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// SharedOptions=--enable-experiment=null-aware-elements
6-
75
import 'package:expect/expect.dart';
86

97
String log = "";

‎tests/language/null_aware_elements/flow_analysis_test.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// SharedOptions=--enable-experiment=null-aware-elements
6-
75
import '../static_type_helper.dart';
86

97
test1(String a, num x) {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /