Commit 48cd348

eulerssonjennifer-shehaneAtofStryker

authored

feat: add explicit check against codeCoverage.expectFrontendCoverageOnly before attempting to collect backend coverage (#555)

Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>

1 parent 2b78406 commit 48cd348Copy full SHA for 48cd348

File tree

+25

-1

lines changed

+25

-1

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,21 @@ After:`
`251`	`251`
`252`	`252`	`![Cypress knows to expect the backend code coverage only](./images/expect-backend.png)`
`253`	`253`
	`254`	`+### expectFrontendCoverageOnly`
	`255`	`+`
	`256`	+If there is ONLY frontend code coverage, set `expectFrontendCoverageOnly: true` in the `cypress.json` file. Otherwise, Cypress complains that it cannot find the frontend code coverage.
	`257`	`+`
	`258`	+```json
	`259`	`+{`
	`260`	`+ "env": {`
	`261`	`+ "codeCoverage": {`
	`262`	`+ "url": "http://localhost:3003/__coverage__",`
	`263`	`+ "expectFrontendCoverageOnly": true`
	`264`	`+ }`
	`265`	`+ }`
	`266`	`+}`
	`267`	+```
	`268`	`+`
`254`	`269`	`## Custom report folder`
`255`	`270`
`256`	`271`	You can specify a custom report folder by adding `nyc` object to the `package.json` file. For example, to save reports to `cypress-coverage` folder, use:

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -178,10 +178,19 @@ const registerHooks = () => {`
`178`	`178`	`const baseUrl = Cypress.config('baseUrl') \|\| cy.state('window').origin`
`179`	`179`	`// @ts-ignore`
`180`	`180`	`const runningEndToEndTests = baseUrl !== Cypress.config('proxyUrl')`
	`181`	`+ const expectFrontendCoverageOnly = Cypress._.get(`
	`182`	`+ Cypress.env('codeCoverage'),`
	`183`	`+ 'expectFrontendCoverageOnly',`
	`184`	`+ false`
	`185`	`+ )`
`181`	`186`	`const specType = Cypress._.get(Cypress.spec, 'specType', 'integration')`
`182`	`187`	`const isIntegrationSpec = specType === 'integration'`
`183`	`188`
`184`		`- if (runningEndToEndTests && isIntegrationSpec) {`
	`189`	`+ if (`
	`190`	`+ !expectFrontendCoverageOnly &&`
	`191`	`+ runningEndToEndTests &&`
	`192`	`+ isIntegrationSpec`
	`193`	`+ ) {`
`185`	`194`	`// we can only request server-side code coverage`
`186`	`195`	`// if we are running end-to-end tests,`
`187`	`196`	`// otherwise where do we send the request?`

Comments

(0)