-
Notifications
You must be signed in to change notification settings - Fork 23
Clean up repo, use CPM for dependency management #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@maztheman
maztheman
commented
Dec 7, 2023
- Update CMake version to 3.21
- Make this repo able to be pulled in as a dependency via CMake
- Use new compiler and environment detection (from range-v3)
- Use CPM for dependencies
- Fix Github actions to work on Clang 10,11,12,14
- Update CMake version to 3.21 - Make this repo able to be pulled in as a dependency via CMake - Use new compiler and environment detection (from range-v3) - Use CPM for dependencies - Fix Github actions to work on Clang 10,11,12,14
vcpkg install in the github action is no longer really needed..but left it in for now
Thanks @maztheman, this is awesome! This needed some attention, I'm happy for the contribution.
I didn't mean to add that second commit, oops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be "skyr_VERBOSE_BUILD"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the new variables I put in has prefix SKY, but that doesn't seem to be consistent with everything else. Should probably be changed.
I didn't mean to add that second commit, oops.
Can you rebase and remove it? Then I'll merge
df58ca3 to
e2e2f8d
Compare
done.