-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Display specific, user-friendly error message when upload categories search API call returns an error #6540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-raoul
merged 4 commits into
commons-app:main
from
ted-gilbert:5225-user-friendly-server-outage
Oct 25, 2025
Merged
Display specific, user-friendly error message when upload categories search API call returns an error #6540
nicolas-raoul
merged 4 commits into
commons-app:main
from
ted-gilbert:5225-user-friendly-server-outage
Oct 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...d API call returns an error
...rch API call returns an error
✅ Generated APK variants!
nicolas-raoul
nicolas-raoul
approved these changes
Oct 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I did not go as far as voluntarily trigger an error, but at least it works for successful search and category not found. 🙂
@nicolas-raoul
nicolas-raoul
merged commit Oct 25, 2025
28fa7b1
into
commons-app:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5225
What changes did you make and why?
Modified the error handling in
UnsuccessfulResponseInterceptor.interceptso thatMwIOExceptionis raised for non-suppressed errors. The error code and details are parsed into aMwLegacyServiceErrorobject, which is attached toMwIOException.Added a method,
showErrorDialog(String)toUploadCategoriesFragmentandCategoriesContractwhich displays an AlertDialog stating that an error has occurred while loading categories and showing a specific error message.Added handling to
CategoriesPresenterinonAttachViewandonAttachViewWithMediawhich displays an alert with the specific MediaWiki API error when the categories search throwsMwIOException.Tests performed (required)
Tested betaDebug on Medium Phone with API level 35.
Tested prodDebug on Medium Phone with API level 35.
Screenshots (for UI changes only)
Categories upload UI showing alert dialog with specific API errorNeed help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.