Commit e7fa49a

authored

Prevent literal "None" placeholders (applegrew#591)

1 parent 39ab326 commit e7fa49aCopy full SHA for e7fa49a

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ def build_attrs(self, base_attrs, extra_attrs=None):`
`80`	`80`	`default_attrs['data-allow-clear'] = 'false'`
`81`	`81`	`else:`
`82`	`82`	`default_attrs['data-allow-clear'] = 'true'`
`83`		`- default_attrs['data-placeholder'] = self.empty_label`
	`83`	`+ default_attrs['data-placeholder'] = self.empty_labelor""`
`84`	`84`
`85`	`85`	`default_attrs.update(base_attrs)`
`86`	`86`	`attrs = super().build_attrs(default_attrs, extra_attrs=extra_attrs)`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,9 @@ def test_empty_option(self, db):`
`95`	`95`	`multiple_select = self.multiple_form.fields['featured_artists']`
`96`	`96`	`assert multiple_select.required is False`
`97`	`97`	`assert multiple_select.widget.allow_multiple_selected`
`98`		`- assert '<option value=""></option>' not in multiple_select.widget.render('featured_artists', None)`
	`98`	`+ output = multiple_select.widget.render('featured_artists', None)`
	`99`	`+ assert '<option value=""></option>' not in output`
	`100`	`+ assert 'data-placeholder=""' in output`
`99`	`101`
`100`	`102`	`def test_i18n(self):`
`101`	`103`	`translation.activate('de')`

Comments

(0)