Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add support for mode parameter for POST /runs #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
championswimmer merged 6 commits into coding-blocks:master from abhishek97:runModes
Jan 24, 2019

Conversation

@abhishek97
Copy link
Contributor

@abhishek97 abhishek97 commented Jan 15, 2019

  • Add support for mode parameter for POST /api/runs
  • Add support for callback mode

Copy link
Contributor Author

#16

Copy link
Contributor Author

@championswimmer see if we can merge this

Copy link

codecov bot commented Jan 24, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@bdb4afe). Click here to learn what that means.
The diff coverage is 55.76%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #19 +/- ##
=========================================
 Coverage ? 68.15% 
=========================================
 Files ? 11 
 Lines ? 179 
 Branches ? 24 
=========================================
 Hits ? 122 
 Misses ? 41 
 Partials ? 16
Impacted Files Coverage Δ
config.js 100% <ø> (ø)
src/db/models.ts 100% <100%> (ø)
src/validators/SubmissionValidators.ts 21.42% <16.66%> (ø)
src/utils/s3.ts 40% <40%> (ø)
src/routes/api/run.ts 70.37% <65.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb4afe...2c2e0b3. Read the comment docs.

Copy link
Contributor Author

@championswimmer tests are green now.

@championswimmer championswimmer merged commit edbc594 into coding-blocks:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /