Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

When code-server declines a websocket request for whatever reason, log that reason. #7195

Unanswered
kimboslice99 asked this question in Ideas
Discussion options

This would prevent the hoards of people complaining about proxy issues. Seems code-server is overly specific about what it wants in request headers, so we should be verbose about this.

You must be logged in to vote

Replies: 1 comment

Comment options

The only time we decline a web socket is due to mismatched origin headers, and we throw a forbidden in that case.

We do also log, but only debug-level. We could make that info level though? I was not sure because if a malicious user is trying to access the site cross-origin you could get spam in the logs with blocking request over and over. Could be solved by adding rate limiting though.

But on the other hand, if there are permanent connection problems like this, it seems reasonable to use debug level to figure them out.

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Ideas
Labels
None yet

AltStyle によって変換されたページ (->オリジナル) /