-
Notifications
You must be signed in to change notification settings - Fork 6.3k
When code-server declines a websocket request for whatever reason, log that reason. #7195
-
This would prevent the hoards of people complaining about proxy issues. Seems code-server is overly specific about what it wants in request headers, so we should be verbose about this.
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 1 comment
-
The only time we decline a web socket is due to mismatched origin headers, and we throw a forbidden in that case.
We do also log, but only debug-level. We could make that info level though? I was not sure because if a malicious user is trying to access the site cross-origin you could get spam in the logs with blocking request over and over. Could be solved by adding rate limiting though.
But on the other hand, if there are permanent connection problems like this, it seems reasonable to use debug level to figure them out.
Beta Was this translation helpful? Give feedback.