-
Notifications
You must be signed in to change notification settings - Fork 6.3k
v4.9.0-rc.3 #5829
-
Code v1.73.1
This is the third pre-release for v4.9.0.
To install via the install script, pass the --edge flag.
This discussion was created from the release v4.9.0-rc.3.
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 1 comment 9 replies
-
@benz0li do you mind testing to see if this issue is fixed?
Beta Was this translation helpful? Give feedback.
All reactions
-
CHECK THIS OUT
I didn't even realize but look at this block of code:
https://github.com/coder/code-server/blob/main/.github/workflows/release.yaml#L315-L324
I bet you that's it. My hunch says before this step, file permissions are correct. Then we use mv and jq and I bet it messes it up! Let's debug and find out.
Beta Was this translation helpful? Give feedback.
All reactions
-
❤️ 1
-
THAT WAS IT!
After we modify the version in the package.json the file permissions change, causing the bug.
https://github.com/coder/code-server/actions/runs/3603913725/jobs/6072677160#step:4:14
Now I need to see if there's a way to mv but keep same file permissions.
Beta Was this translation helpful? Give feedback.
All reactions
-
❤️ 1
-
Alright tested locally and I think this should fix it: 0f66360
Going to do another release candidate.
Beta Was this translation helpful? Give feedback.
All reactions
-
@jsjoeio Thank you for the detailed problem analysis. It's awesome how you do this!
Beta Was this translation helpful? Give feedback.
All reactions
-
❤️ 1
-
Thanks for saying that! It's definitely slower than other approaches, but leaves a note trail for others to see and helps understand everything much better.
Beta Was this translation helpful? Give feedback.