Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

v4.9.0-rc.3 #5829

Dec 1, 2022 · 1 comments · 9 replies
Discussion options

Code v1.73.1

This is the third pre-release for v4.9.0.

To install via the install script, pass the --edge flag.


This discussion was created from the release v4.9.0-rc.3.
You must be logged in to vote

Replies: 1 comment 9 replies

Comment options

@benz0li do you mind testing to see if this issue is fixed?

You must be logged in to vote
9 replies
Comment options

CHECK THIS OUT

I didn't even realize but look at this block of code:

https://github.com/coder/code-server/blob/main/.github/workflows/release.yaml#L315-L324

I bet you that's it. My hunch says before this step, file permissions are correct. Then we use mv and jq and I bet it messes it up! Let's debug and find out.

Comment options

THAT WAS IT!

After we modify the version in the package.json the file permissions change, causing the bug.

file-permissions

https://github.com/coder/code-server/actions/runs/3603913725/jobs/6072677160#step:4:14

Now I need to see if there's a way to mv but keep same file permissions.

Comment options

Alright tested locally and I think this should fix it: 0f66360

Going to do another release candidate.

Comment options

@jsjoeio Thank you for the detailed problem analysis. It's awesome how you do this!

Comment options

Thanks for saying that! It's definitely slower than other approaches, but leaves a note trail for others to see and helps understand everything much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants

AltStyle によって変換されたページ (->オリジナル) /