Commit 9bd3b83

committed

Fix port parseInt error handling

parseInt returns NaN rather than throwing.

1 parent 2c9b4e7 commit 9bd3b83Copy full SHA for 9bd3b83

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,10 +13,8 @@ const getProxyTarget = (`
`13`	`13`	`): string => {`
`14`	`14`	`// If there is a base path, strip it out.`
`15`	`15`	`const base = (req as any).base \|\| ""`
`16`		`- let port: number`
`17`		`- try {`
`18`		`- port = parseInt(req.params.port, 10)`
`19`		`- } catch (err) {`
	`16`	`+ const port = parseInt(req.params.port, 10)`
	`17`	`+ if (isNaN(port)) {`
`20`	`18`	`throw new HttpError("Invalid port", HttpCode.BadRequest)`
`21`	`19`	`}`
`22`	`20`	return `http://0.0.0.0:${port}${opts?.proxyBasePath \|\| ""}/${req.originalUrl.slice(base.length)}`

Comments

(0)