This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit e963f62

committed

PHP: filter out use statements by default

1 parent 4058ff1 commit e963f62Copy full SHA for e963f62

File tree

2 files changed

+32

-25

lines changed

lib/cc/engine/analyzers/php
- main.rb
spec/cc/engine/analyzers/php
- main_spec.rb

2 files changed

+32

-25

lines changed

`‎lib/cc/engine/analyzers/php/main.rb‎`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,9 @@ class Main < CC::Engine::Analyzers::Base`
`15`	`15`	`"*/.php",`
`16`	`16`	`].freeze`
`17`	`17`	`DEFAULT_MASS_THRESHOLD = 28`
	`18`	`+ DEFAULT_FILTERS = [`
	`19`	`+ "(use ___)".freeze,`
	`20`	`+ ].freeze`
`18`	`21`	`POINTS_PER_OVERAGE = 100_000`
`19`	`22`
`20`	`23`	`def transform_sexp(sexp)`
`@@ -32,6 +35,10 @@ def process_file(path)`
`32`	`35`	`def php_parser`
`33`	`36`	`::CC::Engine::Analyzers::Php::Parser`
`34`	`37`	`end`
	`38`	`+`
	`39`	`+ def default_filters`
	`40`	`+ DEFAULT_FILTERS.map { \|filter\| Sexp::Matcher.parse filter }`
	`41`	`+ end`
`35`	`42`	`end`
`36`	`43`	`end`
`37`	`44`	`end`

`‎spec/cc/engine/analyzers/php/main_spec.rb‎`

Lines changed: 25 additions & 25 deletions

Original file line number	Diff line number	Diff line change
`@@ -165,31 +165,31 @@`
`165`	`165`	`end`
`166`	`166`
`167`	`167`	`it "ignores namespace and use declarations" do`
`168`		`- create_source_file("foo.php", <<-EOF)`
`169`		`-<?php`
`170`		`-namespace KeepClear\\Http\\Controllers\\API\\V1;`
`171`		`-use Illuminate\\Http\\Request;`
`172`		`-use KeepClear\\Http\\Controllers\\Controller;`
`173`		`-use KeepClear\\Models\\Comment;`
`174`		`-use KeepClear\\Models\\User;`
`175`		`-use KeepClear\\Models\\Asset;`
`176`		`-use KeepClear\\Traits\\Controllers\\ApiFilter;`
`177`		`-use KeepClear\\Traits\\Controllers\\ApiParseBody;`
`178`		`-use KeepClear\\Traits\\Controllers\\ApiException;`
`179`		`- EOF`
`180`		`-`
`181`		`- create_source_file("bar.php", <<-EOF)`
`182`		`-<?php`
`183`		`-namespace KeepClear\\Http\\Controllers\\API\\V1;`
`184`		`-use Illuminate\\Http\\Request;`
`185`		`-use KeepClear\\Http\\Controllers\\Controller;`
`186`		`-use KeepClear\\Models\\Comment;`
`187`		`-use KeepClear\\Models\\User;`
`188`		`-use KeepClear\\Models\\Asset;`
`189`		`-use KeepClear\\Traits\\Controllers\\ApiFilter;`
`190`		`-use KeepClear\\Traits\\Controllers\\ApiParseBody;`
`191`		`-use KeepClear\\Traits\\Controllers\\ApiException;`
`192`		`- EOF`
	`168`	`+ create_source_file("foo.php", <<~EOPHP)`
	`169`	`+<?php`
	`170`	`+namespace KeepClear\\Http\\Controllers\\API\\V1;`
	`171`	`+use Illuminate\\Http\\Request;`
	`172`	`+use KeepClear\\Http\\Controllers\\Controller;`
	`173`	`+use KeepClear\\Models\\Comment;`
	`174`	`+use KeepClear\\Models\\User;`
	`175`	`+use KeepClear\\Models\\Asset;`
	`176`	`+use KeepClear\\Traits\\Controllers\\ApiFilter;`
	`177`	`+use KeepClear\\Traits\\Controllers\\ApiParseBody;`
	`178`	`+use KeepClear\\Traits\\Controllers\\ApiException;`
	`179`	`+ EOPHP`
	`180`	`+`
	`181`	`+ create_source_file("bar.php", <<~EOPHP)`
	`182`	`+<?php`
	`183`	`+namespace KeepClear\\Http\\Controllers\\API\\V1;`
	`184`	`+use Illuminate\\Http\\Request;`
	`185`	`+use KeepClear\\Http\\Controllers\\Controller;`
	`186`	`+use KeepClear\\Models\\Comment;`
	`187`	`+use KeepClear\\Models\\User;`
	`188`	`+use KeepClear\\Models\\Asset;`
	`189`	`+use KeepClear\\Traits\\Controllers\\ApiFilter;`
	`190`	`+use KeepClear\\Traits\\Controllers\\ApiParseBody;`
	`191`	`+use KeepClear\\Traits\\Controllers\\ApiException;`
	`192`	`+ EOPHP`
`193`	`193`
`194`	`194`	`issues = run_engine(engine_conf).strip.split("0円")`
`195`	`195`	`expect(issues).to be_empty`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit e963f62

File tree

2 files changed

2 files changed

`‎lib/cc/engine/analyzers/php/main.rb‎`

`‎spec/cc/engine/analyzers/php/main_spec.rb‎`

0 commit comments