This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit d5f57fb

committed

Merge pull request #24 from codeclimate/devon/warn-and-error-without-any-enabled-languages

Warn on stderr and raise an exception if no languages are enabled

2 parents 79da837 + 47e981e commit d5f57fbCopy full SHA for d5f57fb

File tree

+21

-2

lines changed

+21

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,8 @@`
`11`	`11`	`module CC`
`12`	`12`	`module Engine`
`13`	`13`	`class Duplication`
`14`		`- DEFAULT_LANGUAGE = 'ruby'.freeze`
	`14`	`+ EmptyLanguagesError = Class.new(StandardError)`
	`15`	`+`
`15`	`16`	`LANGUAGES = {`
`16`	`17`	`"ruby" => ::CC::Engine::Analyzers::Ruby::Main,`
`17`	`18`	`"javascript" => ::CC::Engine::Analyzers::Javascript::Main,`
`@@ -47,7 +48,9 @@ def languages`
`47`	`48`	`languages = engine_config.languages.keys`
`48`	`49`
`49`	`50`	`if languages.empty?`
`50`		`- Array(DEFAULT_LANGUAGE)`
	`51`	`+ message = "Config Error: Unable to run the duplication engine without any languages enabled."`
	`52`	`+ $stderr.puts message`
	`53`	`+ raise EmptyLanguagesError, message`
`51`	`54`	`else`
`52`	`55`	`languages`
`53`	`56`	`end`

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,16 @@`
	`1`	`+require "spec_helper"`
	`2`	`+require "cc/engine/duplication"`
	`3`	`+`
	`4`	`+module CC::Engine`
	`5`	`+ describe "#languages" do`
	`6`	`+ it "Warns to stderr and raises an exception when no languages are enabled" do`
	`7`	`+ engine = Duplication.new(directory: "/code", engine_config: {}, io: StringIO.new)`
	`8`	`+`
	`9`	`+ _, stderr = capture_io do`
	`10`	`+ assert_raises(Duplication::EmptyLanguagesError) { engine.run }`
	`11`	`+ end`
	`12`	`+`
	`13`	`+ stderr.must_match("Config Error: Unable to run the duplication engine without any languages enabled.")`
	`14`	`+ end`
	`15`	`+ end`
	`16`	`+end`

Comments

(0)