This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 39a6772

committed

Sync in our house styleguide

Close #140

1 parent 689c9a4 commit 39a6772Copy full SHA for 39a6772

File tree

1 file changed

+48

-6

lines changed

.rubocop.yml

1 file changed

+48

-6

lines changed

`‎.rubocop.yml‎`

Lines changed: 48 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,14 @@ Style/Documentation:`
`25`	`25`	`Style/StringLiterals:`
`26`	`26`	`EnforcedStyle: double_quotes`
`27`	`27`
	`28`	`+Style/StringLiteralsInInterpolation:`
	`29`	`+ EnforcedStyle: double_quotes`
	`30`	`+`
`28`	`31`	`# Use a trailing comma to keep diffs clean when elements are inserted or removed`
`29`		`-Style/TrailingComma:`
	`32`	`+Style/TrailingCommaInArguments:`
	`33`	`+ EnforcedStyleForMultiline: comma`
	`34`	`+`
	`35`	`+Style/TrailingCommaInLiteral:`
`30`	`36`	`EnforcedStyleForMultiline: comma`
`31`	`37`
`32`	`38`	`# We avoid GuardClause because it can result in "suprise return"`
`@@ -51,10 +57,10 @@ Style/GlobalVars:`
`51`	`57`	`- "$mongo"`
`52`	`58`	`- "$rollout"`
`53`	`59`
`54`		`-# Allow $! in config/initializers`
	`60`	`+# Using english names requires loading an extra module, which is annoying, so`
	`61`	`+# we prefer the perl names for consistency.`
`55`	`62`	`Style/SpecialGlobalVars:`
`56`		`- Exclude:`
`57`		`- - config/initializers/*/`
	`63`	`+ EnforcedStyle: use_perl_names`
`58`	`64`
`59`	`65`	`# We have common cases where has_ and have_ make sense`
`60`	`66`	`Style/PredicateName:`
`@@ -65,8 +71,10 @@ Style/PredicateName:`
`65`	`71`	`# We use %w[ ], not %w( ) because the former looks like an array`
`66`	`72`	`Style/PercentLiteralDelimiters:`
`67`	`73`	`PreferredDelimiters:`
`68`		`- "%w": []`
`69`		`- "%W": []`
	`74`	`+ "%i": "[]"`
	`75`	`+ "%I": "[]"`
	`76`	`+ "%w": "[]"`
	`77`	`+ "%W": "[]"`
`70`	`78`
`71`	`79`	`# Allow "trivial" accessors when defined as a predicate? method`
`72`	`80`	`Style/TrivialAccessors:`
`@@ -79,6 +87,40 @@ Style/Next:`
`79`	`87`	`Style/ModuleFunction:`
`80`	`88`	`Enabled: false`
`81`	`89`
	`90`	`+# Disallow extra spacing for token alignment`
	`91`	`+Style/ExtraSpacing:`
	`92`	`+ AllowForAlignment: false`
	`93`	`+`
	`94`	`+# and/or in conditionals has no meaningful difference (only gotchas), so we`
	`95`	`+# disallow them there. When used for control flow, the difference in precedence`
	`96`	`+# can make for a less noisy expression, as in:`
	`97`	`+#`
	`98`	`+# x = find_x or raise XNotFound`
	`99`	`+#`
	`100`	`+Style/AndOr:`
	`101`	`+ EnforcedStyle: conditionals`
	`102`	`+`
	`103`	`+Style/AlignParameters:`
	`104`	`+ EnforcedStyle: with_fixed_indentation`
	`105`	`+`
	`106`	`+Style/MultilineOperationIndentation:`
	`107`	`+ EnforcedStyle: indented`
	`108`	`+`
	`109`	`+Style/AlignHash:`
	`110`	`+ EnforcedLastArgumentHashStyle: ignore_implicit`
	`111`	`+`
	`112`	`+# This has the behavior we want, but it has a bug in it which produces a lot of false positives`
	`113`	`+# https://github.com/bbatsov/rubocop/issues/3462`
	`114`	`+# MultilineMethodCallBraceLayout:`
	`115`	`+# EnforcedStyle: new_line`
	`116`	`+`
	`117`	`+################################################################################`
	`118`	`+# Performance`
	`119`	`+################################################################################`
	`120`	`+`
	`121`	`+Performance/RedundantMerge:`
	`122`	`+ Enabled: false`
	`123`	`+`
`82`	`124`	`################################################################################`
`83`	`125`	`# Rails - disable things because we're primarily non-rails`
`84`	`126`	`################################################################################`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 39a6772

File tree

1 file changed

1 file changed

`‎.rubocop.yml‎`

0 commit comments