This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 182ecf2

committed

Merge pull request #60 from codeclimate/will/command-line-running

Use .capture3 not .popen3 for external parsers

2 parents f528659 + 0982eeb commit 182ecf2Copy full SHA for 182ecf2

File tree

-17

lines changed

-17

lines changed

Lines changed: 5 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,23 +14,11 @@ def initialize(command, timeout = DEFAULT_TIMEOUT)`
`14`	`14`
`15`	`15`	`def run(input)`
`16`	`16`	`Timeout.timeout(timeout) do`
`17`		`- Open3.popen3 command, "r+" do \|stdin, stdout, stderr, wait_thr\|`
`18`		`- stdin.puts input`
`19`		`- stdin.close`
`20`		`-`
`21`		`- exit_code = wait_thr.value`
`22`		`-`
`23`		`- output = stdout.gets`
`24`		`- stdout.close`
`25`		`-`
`26`		`- err_output = stderr.gets`
`27`		`- stderr.close`
`28`		`-`
`29`		`- if 0 == exit_code`
`30`		`- yield output`
`31`		`- else`
`32`		`- raise ::CC::Engine::Analyzers::ParserError, "Python parser exited with code #{exit_code}:\n#{err_output}"`
`33`		`- end`
	`17`	`+ out, err, status = Open3.capture3(command, stdin_data: input)`
	`18`	`+ if status.success?`
	`19`	`+ yield out`
	`20`	`+ else`
	`21`	+ raise ::CC::Engine::Analyzers::ParserError, "`#{command}` exited with code #{status.exitstatus}:\n#{err}"
`34`	`22`	`end`
`35`	`23`	`end`
`36`	`24`	`end`

Comments

(0)