This repository was archived by the owner on Jul 19, 2025. It is now read-only.

Commit 0e9b530

committed

Be more explicit in the name of clarity

Before merging my last PR, I pulled this out into a method. I noticed after merging that, outside of the context of the rescue block, a bare `raise` (without specifying the exception) is a little confusing. Raise what? I double checked, and it actually works the same -- it raises the error from $ERROR_INFO, which is the active error. But I still think it's worth being more explicit. https://gist.github.com/maxjacobson/e807c26444810aec1d2b0f4a91d03213

1 parent e704503 commit 0e9b530Copy full SHA for 0e9b530

File tree

1 file changed

-1

lines changed

lib/cc/engine/analyzers
- analyzer_base.rb

1 file changed

-1

lines changed

`‎lib/cc/engine/analyzers/analyzer_base.rb‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ def unexpected_parse_error!(ex)`
`150`	`150`	`CC.logger.error(ex.message)`
`151`	`151`	`CC.logger.debug { "Contents:\n#{processed_source.raw_source}" }`
`152`	`152`
`153`		`- raise`
	`153`	`+ raiseex`
`154`	`154`	`end`
`155`	`155`	`end`
`156`	`156`	`end`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 0e9b530

File tree

1 file changed

1 file changed

`‎lib/cc/engine/analyzers/analyzer_base.rb‎`

0 commit comments