-
-
Notifications
You must be signed in to change notification settings - Fork 240
CSS transition add #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS transition add #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I've added some fairly minor comments. Let me know what you think :)
html/lesson5/tutorial.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By chaning do you mean changing or chaining?
html/lesson5/tutorial.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the wording in this paragraph could be improved, but it's not essential. How about something like this though?
Let's modify a **property** in our code - e.g. the button link `background` colour - so that it changes when you hover over the button. By default, the change will happen instantaneously. However we can animate the effect so that it changes slowly over time, using the **transition** property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need all these line breaks?
oops I reviewed an old commit by mistake, sorry! I've no idea how this happened because I actively tried to avoid this.
@richardwestenra all of your comments are not on my updates, those are marias that I merged into another branch and amended.
@richardwestenra just saw your new comment 😂
I added in Maria's CSS transition addition from 24 PR and got distracted and made some little wording amendments.