Commit b5457a5

authored

Fix demo cover set position action (home-assistant#154641)

1 parent e4b5e35 commit b5457a5Copy full SHA for b5457a5

File tree

2 files changed

+31

-0

lines changed

homeassistant/components/demo
- cover.py
tests/components/demo
- test_cover.py

2 files changed

+31

-0

lines changed

`‎homeassistant/components/demo/cover.py‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,7 @@ async def async_close_cover(self, **kwargs: Any) -> None:`
`139`	`139`	`self.async_write_ha_state()`
`140`	`140`	`return`
`141`	`141`
	`142`	`+ self._is_opening = False`
`142`	`143`	`self._is_closing = True`
`143`	`144`	`self._listen_cover()`
`144`	`145`	`self._requested_closing = True`
`@@ -162,6 +163,7 @@ async def async_open_cover(self, **kwargs: Any) -> None:`
`162`	`163`	`return`
`163`	`164`
`164`	`165`	`self._is_opening = True`
	`166`	`+ self._is_closing = False`
`165`	`167`	`self._listen_cover()`
`166`	`168`	`self._requested_closing = False`
`167`	`169`	`self.async_write_ha_state()`
`@@ -181,10 +183,14 @@ async def async_set_cover_position(self, **kwargs: Any) -> None:`
`181`	`183`	`if self._position == position:`
`182`	`184`	`return`
`183`	`185`
	`186`	`+ self._is_closing = position < (self._position or 0)`
	`187`	`+ self._is_opening = not self._is_closing`
	`188`	`+`
`184`	`189`	`self._listen_cover()`
`185`	`190`	`self._requested_closing = (`
`186`	`191`	`self._position is not None and position < self._position`
`187`	`192`	`)`
	`193`	`+ self.async_write_ha_state()`
`188`	`194`
`189`	`195`	`async def async_set_cover_tilt_position(self, **kwargs: Any) -> None:`
`190`	`196`	`"""Move the cover til to a specific position."""`

`‎tests/components/demo/test_cover.py‎`

Lines changed: 25 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -154,19 +154,44 @@ async def test_set_cover_position(hass: HomeAssistant) -> None:`
`154`	`154`	`"""Test moving the cover to a specific position."""`
`155`	`155`	`state = hass.states.get(ENTITY_COVER)`
`156`	`156`	`assert state.attributes[ATTR_CURRENT_POSITION] == 70`
	`157`	`+`
	`158`	`+ # close to 10%`
`157`	`159`	`await hass.services.async_call(`
`158`	`160`	`COVER_DOMAIN,`
`159`	`161`	`SERVICE_SET_COVER_POSITION,`
`160`	`162`	`{ATTR_ENTITY_ID: ENTITY_COVER, ATTR_POSITION: 10},`
`161`	`163`	`blocking=True,`
`162`	`164`	`)`
	`165`	`+ state = hass.states.get(ENTITY_COVER)`
	`166`	`+ assert state.state == CoverState.CLOSING`
	`167`	`+`
`163`	`168`	`for _ in range(6):`
`164`	`169`	`future = dt_util.utcnow() + timedelta(seconds=1)`
`165`	`170`	`async_fire_time_changed(hass, future)`
`166`	`171`	`await hass.async_block_till_done()`
`167`	`172`
`168`	`173`	`state = hass.states.get(ENTITY_COVER)`
`169`	`174`	`assert state.attributes[ATTR_CURRENT_POSITION] == 10`
	`175`	`+ assert state.state == CoverState.OPEN`
	`176`	`+`
	`177`	`+ # open to 80%`
	`178`	`+ await hass.services.async_call(`
	`179`	`+ COVER_DOMAIN,`
	`180`	`+ SERVICE_SET_COVER_POSITION,`
	`181`	`+ {ATTR_ENTITY_ID: ENTITY_COVER, ATTR_POSITION: 80},`
	`182`	`+ blocking=True,`
	`183`	`+ )`
	`184`	`+ state = hass.states.get(ENTITY_COVER)`
	`185`	`+ assert state.state == CoverState.OPENING`
	`186`	`+`
	`187`	`+ for _ in range(7):`
	`188`	`+ future = dt_util.utcnow() + timedelta(seconds=1)`
	`189`	`+ async_fire_time_changed(hass, future)`
	`190`	`+ await hass.async_block_till_done()`
	`191`	`+`
	`192`	`+ state = hass.states.get(ENTITY_COVER)`
	`193`	`+ assert state.attributes[ATTR_CURRENT_POSITION] == 80`
	`194`	`+ assert state.state == CoverState.OPEN`
`170`	`195`
`171`	`196`
`172`	`197`	`async def test_stop_cover(hass: HomeAssistant) -> None:`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit b5457a5

File tree

2 files changed

2 files changed

`‎homeassistant/components/demo/cover.py‎`

`‎tests/components/demo/test_cover.py‎`

0 commit comments