Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit d81412b

Browse files
Merge pull request #3 from code-yeongyu/feature/fix-tests
Fix tests that are not passing
2 parents b1bc781 + b176f93 commit d81412b

File tree

3 files changed

+15
-18
lines changed

3 files changed

+15
-18
lines changed

‎revChatGPTAuth/openai_cookie_parser.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
class OpenAICookieParser:
99

10-
SUPPORTED_BROWSERS = [browser.value for browser in SupportedBrowser]
10+
SUPPORTED_BROWSERS: list[str] = [browser.value for browser in SupportedBrowser]
1111

1212
def __init__(self, browser_name: SupportedBrowser):
1313
self.BROWSER_NAME = browser_name

‎revChatGPTAuth/test/test_chatgpt_access_token_parser.py‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from unittest.mock import MagicMock, patch
22

33
from revChatGPTAuth.chatgpt_access_token_parser import ChatGPTAccessTokenParser, get_access_token
4+
from revChatGPTAuth.supported_browser import SupportedBrowser
45

56

67
class TestChatGPTAccessTokenParser:
@@ -24,7 +25,7 @@ def test_get_openai_chatgpt_access_token(
2425
mock_response.json.return_value = {'accessToken': expected_access_token}
2526
mock_httpx_get.return_value = mock_response
2627

27-
chatgpt_access_token_parser = ChatGPTAccessTokenParser('chrome')
28+
chatgpt_access_token_parser = ChatGPTAccessTokenParser(SupportedBrowser.CHROME)
2829

2930
# when
3031
access_token = chatgpt_access_token_parser.get_access_token()
@@ -43,11 +44,11 @@ def test_get_openai_chatgpt_access_token(
4344
def test_get_access_token(mock_chatgpt_access_token_parser: MagicMock) -> None:
4445
# given
4546
expected_access_token = 'access_token'
46-
mock_chatgpt_access_token_parser.return_value.get_openai_chatgpt_access_token.return_value = expected_access_token
47+
mock_chatgpt_access_token_parser.return_value.get_access_token.return_value = expected_access_token
4748

4849
# when
49-
access_token = get_access_token('chrome')
50+
access_token = get_access_token(SupportedBrowser.CHROME)
5051

5152
# then
52-
mock_chatgpt_access_token_parser.assert_called_once_with('chrome')
53+
mock_chatgpt_access_token_parser.assert_called_once_with(SupportedBrowser.CHROME)
5354
assert access_token == expected_access_token

‎revChatGPTAuth/test/test_openai_cookie_parser.py‎

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,29 @@
1-
from http.cookiejar import Cookie
1+
from http.cookiejar import Cookie, CookieJar
22
from unittest.mock import MagicMock, patch
33

44
import pytest
5-
from yt_dlp.cookies import SUPPORTED_BROWSERS
6-
from yt_dlp.utils import YoutubeDLCookieJar
75

86
from revChatGPTAuth.openai_cookie_parser import OpenAICookieParser
7+
from revChatGPTAuth.supported_browser import SupportedBrowser
98

109

1110
class TestOpenAICookieParser:
12-
13-
def test_init_with_unsupported_browser(self):
14-
with pytest.raises(ValueError):
15-
OpenAICookieParser(browser_name='Internet Explorer Holy Shit')
11+
SUPPORTED_BROWSERS = [SupportedBrowser(browser_name) for browser_name in OpenAICookieParser.SUPPORTED_BROWSERS]
1612

1713
@pytest.mark.parametrize('supported_browser', SUPPORTED_BROWSERS)
18-
def test_init_with_supported_browser(self, supported_browser: str):
14+
def test_init_with_supported_browser(self, supported_browser: SupportedBrowser):
1915
parser = OpenAICookieParser(browser_name=supported_browser)
2016
assert parser.BROWSER_NAME == supported_browser
2117

2218
@pytest.mark.parametrize('supported_browser', SUPPORTED_BROWSERS)
23-
@patch('revChatGPTAuth.openai_cookie_parser.extract_cookies_from_browser')
19+
@patch('revChatGPTAuth.openai_cookie_parser.load_cookies')
2420
def test_parse_cookie_with_supported_browser(
2521
self,
26-
mock_extract_cookies: MagicMock,
27-
supported_browser: str,
22+
mock_load_cookies: MagicMock,
23+
supported_browser: SupportedBrowser,
2824
):
2925
# given
30-
cookie_jar = YoutubeDLCookieJar()
26+
cookie_jar = CookieJar()
3127
cookie_jar.set_cookie(
3228
Cookie(
3329
version=0,
@@ -85,7 +81,7 @@ def test_parse_cookie_with_supported_browser(
8581
comment_url=None,
8682
rest={},
8783
))
88-
mock_extract_cookies.return_value = cookie_jar
84+
mock_load_cookies.return_value = cookie_jar
8985
parser = OpenAICookieParser(browser_name=supported_browser)
9086

9187
# when

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /