-
Notifications
You must be signed in to change notification settings - Fork 16
support TFS git URLs #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
26aaee6 to
ee47864
Compare
improving the regex to parse more exotic URLs. Signed-off-by: André Roth <neolynx@gmail.com>
ee47864 to
c19812b
Compare
HaloGithub
commented
Apr 13, 2020
@sobh
sobh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch solves a problem I have with repositories owned by user with an all digits username on GitHub (I know 🤦♂️).
E.g.
Thus, the actual username gets wrongfully recognized as the port number. Leaving the owner empty.
Please 🙏 merge.
hi @HaloGithub I was the original author of this project, however, it has been transitioned to the Cola team. While I approve the PR, I probably shouldn't merge it, as I'm not responsible for releasing it. Might be best to reach out to the Cola project owners.
improving the regex to parse more exotic URLs.
Signed-off-by: André Roth neolynx@gmail.com