This repository was archived by the owner on Sep 3, 2021. It is now read-only.

Commit f58b5ad

committed

refactor(controllers): fix the destroy tests

100% coverage

1 parent a7bdd69 commit f58b5adCopy full SHA for f58b5ad

File tree

+12

-9

lines changed

+12

-9

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,11 +4,10 @@`
`4`	`4`	`angular.module('myApp')`
`5`	`5`	`.controller('SampleController', SampleController);`
`6`	`6`
`7`		`- function SampleController($scope) {`
	`7`	`+ function SampleController($scope,sampleService) {`
`8`	`8`	`var vm = this;`
`9`	`9`
`10`	`10`	`vm.bar = bar;`
`11`		`- vm.doSomething = doSomething;`
`12`	`11`	`vm.sendMessage = sendMessage;`
`13`	`12`	`vm.broadcastEvent = broadcastEvent;`
`14`	`13`	`vm.foo = 'bar';`
`@@ -17,8 +16,6 @@`
`17`	`16`	`vm.foo = 'baz';`
`18`	`17`	`}`
`19`	`18`
`20`		`- function doSomething() {}`
`21`		`-`
`22`	`19`	`function sendMessage() {`
`23`	`20`	`$scope.$emit('sample:message', { foo: 'bar' });`
`24`	`21`	`}`
`@@ -34,10 +31,14 @@`
`34`	`31`	`});`
`35`	`32`
`36`	`33`	`$scope.$on('$destroy', function() {`
`37`		`- vm.doSomething();`
	`34`	`+ sampleService.bar();`
`38`	`35`	`});`
`39`	`36`
`40`	`37`	`//scope.$on()`
`41`	`38`	`//scope.$apply()`
`42`	`39`	`}`
	`40`	`+`
	`41`	`+ SampleController.$inject = ['$scope', 'sampleService'];`
`43`	`42`	`}());`
	`43`	`+`
	`44`	`+`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,13 @@`
`1`	`1`	`describe('SampleController', function() {`
`2`	`2`	`var $rootScope,`
`3`		`- ctrl, scope;`
	`3`	`+ ctrl, scope,sampleService;`
`4`	`4`
`5`	`5`	`beforeEach(module('myApp'));`
`6`	`6`
`7`		`- beforeEach(inject(function( _$rootScope_, _$controller_) {`
	`7`	`+ beforeEach(inject(function( _$rootScope_, _$controller_,_sampleService_) {`
`8`	`8`	`$rootScope = _$rootScope_;`
`9`	`9`	`scope = $rootScope.$new();`
	`10`	`+ sampleService = _sampleService_;`
`10`	`11`
`11`	`12`	`ctrl = _$controller_('SampleController', {`
`12`	`13`	`$scope: scope`
`@@ -23,15 +24,16 @@ describe('SampleController', function() {`
`23`	`24`	`});`
`24`	`25`
`25`	`26`	`it('should have a watcher', function() {`
	`27`	`+ scope.$digest(); // run once before change a value just to make the coverage 100%`
`26`	`28`	`scope.baz = 'foo';`
`27`	`29`	`scope.$digest();`
`28`	`30`	`expect(ctrl.baz).toBe('foobar');`
`29`	`31`	`});`
`30`	`32`
`31`	`33`	`it('should do something on $destroy', function() {`
`32`		`- spyOn(ctrl, 'doSomething');`
	`34`	`+ spyOn(sampleService, 'bar');`
`33`	`35`	`scope.$destroy();`
`34`		`- expect(ctrl.doSomething).toHaveBeenCalled();`
	`36`	`+ expect(sampleService.bar).toHaveBeenCalled();`
`35`	`37`	`});`
`36`	`38`
`37`	`39`	`it('should emit an event', function() {`

Comments

(0)