-
-
Notifications
You must be signed in to change notification settings - Fork 320
-
The composer.json file lists the "fileinfo" extension in the "require" section.
As far as I can tell, fileinfo functions are only used by the Imagick output format.
src/Output/QRImagick.php contains extension_loaded checks for imagick and fileinfo and aborts if either is missing.
The "imagick" extension is not required in composer.json.
It seems counterintuitive to require fileinfo but not imagick. Consistency would suggest including both or neither.
Many (most?) use cases do not involve the Imagick output format, which would seem to favor neither.
Would it make sense to move fileinfo from "require" to "suggest" and add imagick there as well?
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
Replies: 1 comment 1 reply
-
Hey, that's a good point! I didn't think about that when i added it. Will change soon!
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
-
Fixed in 2b36fa9
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1