Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fileinfo required by composer.json #186

jdwx started this conversation in Ideas
Mar 15, 2023 · 1 comments · 1 reply
Discussion options

The composer.json file lists the "fileinfo" extension in the "require" section.

As far as I can tell, fileinfo functions are only used by the Imagick output format.

src/Output/QRImagick.php contains extension_loaded checks for imagick and fileinfo and aborts if either is missing.

The "imagick" extension is not required in composer.json.

It seems counterintuitive to require fileinfo but not imagick. Consistency would suggest including both or neither.

Many (most?) use cases do not involve the Imagick output format, which would seem to favor neither.

Would it make sense to move fileinfo from "require" to "suggest" and add imagick there as well?

You must be logged in to vote

Replies: 1 comment 1 reply

Comment options

Hey, that's a good point! I didn't think about that when i added it. Will change soon!

You must be logged in to vote
1 reply
Comment options

Fixed in 2b36fa9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Ideas
Labels
None yet
2 participants

AltStyle によって変換されたページ (->オリジナル) /