Commit 93f3568

authored

optimize Pipe.Wait (#187)

use io.Copy with io.Discard instead of io.ReadAll to avoid allocating a buffer just to throw it away

1 parent b4160e2 commit 93f3568Copy full SHA for 93f3568

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -849,7 +849,7 @@ func (p Pipe) Tee(writers ...io.Writer) Pipe {`
`849`	`849`	`// useful for waiting until concurrent filters have completed (see`
`850`	`850`	`// [Pipe.Filter]).`
`851`	`851`	`func (p *Pipe) Wait() {`
`852`		`- _, err := io.ReadAll(p)`
	`852`	`+ _, err := io.Copy(io.Discard, p)`
`853`	`853`	`if err != nil {`
`854`	`854`	`p.SetError(err)`
`855`	`855`	`}`

Comments

(0)