Commit fcf3db6

committed

fix(linkedlist): rename indexOf to getIndex to make it clearer

1 parent 7659ac6 commit fcf3db6Copy full SHA for fcf3db6

File tree

+11

-8

lines changed

+11

-8

lines changed

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,14 +101,17 @@ class LinkedList {`
`101`	`101`	`/**`
`102`	`102`	`* Search by value. It finds first occurrence of`
`103`	`103`	`* the position of element matching the value.`
	`104`	`+ * Similar to Array.indexOf.`
	`105`	`+ *`
`104`	`106`	`* Runtime: O(n)`
	`107`	`+ *`
`105`	`108`	`* @example: assuming a linked list with: a -> b -> c`
`106`		`- * linkedList.indexOf('b') // ↪️ 1`
`107`		`- * linkedList.indexOf('z') // ↪️ undefined`
	`109`	`+ * linkedList.getIndexByValue('b') // ↪️ 1`
	`110`	`+ * linkedList.getIndexByValue('z') // ↪️ undefined`
`108`	`111`	`* @param {any} value`
`109`	`112`	`* @returns {number} return index or undefined`
`110`	`113`	`*/`
`111`		`- indexOf(value) {`
	`114`	`+ getIndexByValue(value) {`
`112`	`115`	`return this.find((current, position) => {`
`113`	`116`	`if (current.value === value) {`
`114`	`117`	`return position;`
`@@ -142,7 +145,7 @@ class LinkedList {`
`142`	`145`	`// tag::find[]`
`143`	`146`	`/**`
`144`	`147`	`* Iterate through the list until callback returns a truthy value`
`145`		`- * @example see #get and #indexOf`
	`148`	`+ * @example see #get and #getIndexByValue`
`146`	`149`	`* @param {Function} callback evaluates current node and index.`
`147`	`150`	`* If any value other than undefined it's returned it will stop the search.`
`148`	`151`	`* @returns {any} callbacks's return value or undefined`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -122,14 +122,14 @@ describe('LinkedList Test', () => {`
`122`	`122`	`});`
`123`	`123`	`});`
`124`	`124`
`125`		`- describe('#indexOf', () => {`
	`125`	`+ describe('#getIndexByValue', () => {`
`126`	`126`	`it('should find element index', () => {`
`127`		`- expect(linkedList.indexOf(0)).toBe(0);`
`128`		`- expect(linkedList.indexOf('found')).toBe(1);`
	`127`	`+ expect(linkedList.getIndexByValue(0)).toBe(0);`
	`128`	`+ expect(linkedList.getIndexByValue('found')).toBe(1);`
`129`	`129`	`});`
`130`	`130`
`131`	`131`	`it('should return undefined', () => {`
`132`		`- expect(linkedList.indexOf('hola')).toBe(undefined);`
	`132`	`+ expect(linkedList.getIndexByValue('hola')).toBe(undefined);`
`133`	`133`	`});`
`134`	`134`	`});`
`135`	`135`

Comments

(0)