Commit dcd941d

committed

Default to creating virtualenv using Python used to invoke ebcli_installer.py

The current behaviour of the ebcli_installer.py is to not pass a Python executable's PATH to virtualenv to create a sandbox for the EB CLI. As a result, virtualenv may use a Python other than the one used to invoke ebcli_installer.py. This behaviour is confusing. On some systems where the default Python is 2.7, virtualenv may use that, thereby defeating the goal to use the latest and greatest. This commit ensures that ebcli_installer.py passes the path to the Python executable used to invoke it to virtualenv to create a sandbox for the EB CLI with.

1 parent 8306771 commit dcd941dCopy full SHA for dcd941d

File tree

1 file changed

-0

lines changed

scripts
- ebcli_installer.py

1 file changed

-0

lines changed

`‎scripts/ebcli_installer.py‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -426,6 +426,7 @@ def _create_virtualenv(`
`426`	`426`	`"""`
`427`	`427`	`virtualenv_location = virtualenv_location or _user_local_directory()`
`428`	`428`	`virtualenv_directory = os.path.join(virtualenv_location, VIRTUALENV_DIR_NAME)`
	`429`	`+ python_installation = python_installation or sys.executable`
`429`	`430`
`430`	`431`	`if (`
`431`	`432`	`os.path.exists(virtualenv_directory)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit dcd941d

File tree

1 file changed

1 file changed

`‎scripts/ebcli_installer.py‎`

0 commit comments