-
-
Notifications
You must be signed in to change notification settings - Fork 322
feat: add configurable page load state #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasAlvws
LucasAlvws
approved these changes
Aug 28, 2025
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
@thalissonvs
thalissonvs
deleted the
codex/add-page_load_state-enum-to-options
branch
October 5, 2025 17:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Closes #218
Summary
PageLoadStateenum for document readinesspage_load_statevia Options and wait loopTesting
PYENV_VERSION=3.11.12 pytest tests/test_browser/test_browser_options.pyPYENV_VERSION=3.11.12 pytest(fails: No module named 'aioresponses')https://chatgpt.com/codex/tasks/task_e_68ab7795b1b083208903f71dbb55c70c