-
-
Notifications
You must be signed in to change notification settings - Fork 12
Update project Go version to 1.24.8 #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several changes were required to accompany the version number bumps: Image Name ---------- It was necessary to change the format of the name of the image used for the Linux ARM 64-bit release builds from: `docker.elastic.co/beats-dev/golang-crossbuild:1.24.0-arm` to: `docker.elastic.co/beats-dev/golang-crossbuild:1.24.8-base-arm-debian10` This is due to an change in the `docker.elastic.co/beats-dev/golang-crossbuild` image naming scheme, starting from 1.24.1. Without the change, the build would fail: ``` docker: Error response from daemon: manifest for docker.elastic.co/beats-dev/golang-crossbuild:1.24.8-arm not found: manifest unknown: manifest unknown ``` Runner for Linux ARM 64-bit Release Builds ------------------------------------------ Previously, the `ubuntu-latest` GitHub Actions runner was used for the matrix job of the Linux ARM 64-bit release builds. However, the `docker.elastic.co/beats-dev/golang-crossbuild:1.24.8-base-arm-debian10` image fails to run on this runner: ``` WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested exec /crossbuild: exec format error ``` The incompatibility is solved by changing to the Linux ARM runner `ubuntu-24.04-arm`, as was previously done to solve the same problem for the macOS ARM build. It is standard practice to use the "latest" GitHub Actions runner identifiers in the project's workflows, which causes the workflow runs to always use the newest stable runner version. However, GitHub has broken from this established convention by choosing to not provide "latest" identifiers for the Linux ARM runners. For this reason, the version-specific runner name was used in the workflow. It will be necessary to manually update the runner name as new stable versions are made available (or more likely fail to do so until forced after GitHub's removal of the runner in use breaks the workflows).
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: infrastructure
Related to project infrastructure
labels
Nov 1, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #985 +/- ## ======================================= Coverage 83.33% 83.33% ======================================= Files 1 1 Lines 180 180 ======================================= Hits 150 150 Misses 19 19 Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes were required to accompany the version number bumps:
Image Name
It was necessary to change the format of the name of the image used for the Linux ARM 64-bit release builds from:
docker.elastic.co/beats-dev/golang-crossbuild:1.24.0-armto:
docker.elastic.co/beats-dev/golang-crossbuild:1.24.8-base-arm-debian10This is due to an change in the
docker.elastic.co/beats-dev/golang-crossbuildimage naming scheme, starting from 1.24.1 (elastic/golang-crossbuild#545, elastic/golang-crossbuild#639).Without the change, the build would fail:
Runner for Linux ARM 64-bit Release Builds
Previously, the
ubuntu-latestGitHub Actions runner was used for the matrix job of the Linux ARM 64-bit release builds. However, thedocker.elastic.co/beats-dev/golang-crossbuild:1.24.8-base-arm-debian10image fails to run on this runner:The incompatibility is solved by changing to the Linux ARM runner
ubuntu-24.04-arm, as was previously done to solve the same problem for the macOS ARM build (#952).It is standard practice to use the "latest" GitHub Actions runner identifiers in the project's workflows, which causes the workflow runs to always use the newest stable runner version. However, GitHub has broken from this established convention by choosing to not provide "latest" identifiers for the Linux ARM runners (actions/partner-runner-images#118 (comment)). For this reason, the version-specific runner name was used in the workflow. It will be necessary to manually update the runner name as new stable versions are made available (or more likely fail to do so until forced after GitHub's removal of the runner in use breaks the workflows).