Commit ee43a12

Akos Kittakittaakos

Akos Kitta

authored and

committed

fix: show no errors if users cancel lib install

Throwing and catching a `UserAbortError` is part of the natural flow. Closes #2063 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent 31deeeb commit ee43a12Copy full SHA for ee43a12

File tree

-1

lines changed

arduino-ide-extension/src/browser/widgets/component-list
- filterable-list-container.tsx

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ import {`
`13`	`13`	`} from '../../../common/protocol/installable';`
`14`	`14`	`import { ArduinoComponent } from '../../../common/protocol/arduino-component';`
`15`	`15`	`import { SearchBar } from './search-bar';`
`16`		`-import { ListWidget } from './list-widget';`
	`16`	`+import { ListWidget,UserAbortError } from './list-widget';`
`17`	`17`	`import { ComponentList } from './component-list';`
`18`	`18`	`import { ListItemRenderer } from './list-item-renderer';`
`19`	`19`	`import {`
`@@ -148,6 +148,11 @@ export class FilterableListContainer<`
`148`	`148`	`try {`
`149`	`149`	`await install({ item, progressId, version });`
`150`	`150`	`} catch (err) {`
	`151`	`+ if (err instanceof UserAbortError) {`
	`152`	`+ // Do not toast an error message on user abort.`
	`153`	`+ // https://github.com/arduino/arduino-ide/issues/2063`
	`154`	`+ return;`
	`155`	`+ }`
`151`	`156`	`const message = LibraryPackage.is(item) // TODO: this dispatch does not belong here`
`152`	`157`	`? libraryInstallFailed(name, version)`
`153`	`158`	`: platformInstallFailed(name, version);`

Comments

(0)