Commit 5e6725d

author

Akos Kitta

committed

Removed the min window height and width.

Made the boards config dialog slightly smaller. Closes #216. Signed-off-by: Akos Kitta <kittaakos@typefox.io>

1 parent f6e623c commit 5e6725dCopy full SHA for 5e6725d

File tree

3 files changed

+11

-31

lines changed

arduino-ide-extension/src
- browser
  - boards
    - boards-config-dialog.ts
  - style
    - boards-config-dialog.css
- electron-main/theia
  - electron-main-application.ts

3 files changed

+11

-31

lines changed

`‎arduino-ide-extension/src/browser/boards/boards-config-dialog.ts‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ export class BoardsConfigDialog extends AbstractDialog<BoardsConfig.Config> {`
`69`	`69`	`'Select both a Board and a Port if you want to upload a sketch.',`
`70`	`70`	`'If you only select a Board you will be able just to compile, but not to upload your sketch.'`
`71`	`71`	`]) {`
`72`		`- const p = document.createElement('p');`
	`72`	`+ const p = document.createElement('div');`
`73`	`73`	`p.textContent = paragraph;`
`74`	`74`	`text.appendChild(p);`
`75`	`75`	`}`

`‎arduino-ide-extension/src/browser/style/boards-config-dialog.css‎`

Lines changed: 10 additions & 20 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,26 +1,22 @@`
`1`	`1`	`div#select-board-dialog {`
`2`		`- margin: 5px20px50px20px;`
	`2`	`+ margin: 5px;`
`3`	`3`	`}`
`4`	`4`
`5`	`5`	`div#select-board-dialog .selectBoardContainer .body {`
`6`	`6`	`display: flex;`
`7`	`7`	`overflow: hidden;`
`8`	`8`	`}`
`9`	`9`
`10`		`-div.dialogContent.select-board-dialog >div.head {`
`11`		`- padding-left:21px;`
	`10`	`+.select-board-dialog .head {`
	`11`	`+ margin:5px;`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`div.dialogContent.select-board-dialog > div.head .title {`
`15`	`15`	`font-weight: 400;`
`16`	`16`	`letter-spacing: .02em;`
`17`	`17`	`font-size: 1.2em;`
`18`	`18`	`color: var(--theia-arduino-branding-primary);`
`19`		`- margin: 17px 0;`
`20`		`-}`
`21`		`-`
`22`		`-div#select-board-dialog .selectBoardContainer .head .text {`
`23`		`- margin-bottom: 21px;`
	`19`	`+ margin-bottom: 10px;`
`24`	`20`	`}`
`25`	`21`
`26`	`22`	`div#select-board-dialog .selectBoardContainer .body .list .item.selected {`
`@@ -82,9 +78,9 @@ div#select-board-dialog .selectBoardContainer .body .list .item.selected i {`
`82`	`78`	`color: var(--theia-arduino-branding-secondary);`
`83`	`79`	`padding: 10px 5px 10px 10px;`
`84`	`80`	`text-transform: uppercase;`
`85`		- /* The max, min-height comes from `.body .list` 265px + 47px top padding - 2 * 10px top padding */
`86`		`- max-height: 292px;`
`87`		`- min-height: 292px;`
	`81`	+ /* The max, min-height comes from `.body .list` 200px + 47px top padding - 2 * 10px top padding */
	`82`	`+ max-height: 227px;`
	`83`	`+ min-height: 227px;`
`88`	`84`	`}`
`89`	`85`
`90`	`86`	`#select-board-dialog .selectBoardContainer .body .list .item {`
`@@ -115,8 +111,8 @@ div#select-board-dialog .selectBoardContainer .body .list .item.selected i {`
`115`	`111`	`}`
`116`	`112`
`117`	`113`	`#select-board-dialog .selectBoardContainer .body .list {`
`118`		`- max-height: 265px;`
`119`		`- min-height: 265px;`
	`114`	`+ max-height: 200px;`
	`115`	`+ min-height: 200px;`
`120`	`116`	`overflow-y: auto;`
`121`	`117`	`}`
`122`	`118`
`@@ -132,14 +128,8 @@ div#select-board-dialog .selectBoardContainer .body .list .item.selected i {`
`132`	`128`	`}`
`133`	`129`
`134`	`130`	`.p-Widget.dialogOverlay .dialogContent.select-board-dialog {`
`135`		`- width: 740px;`
	`131`	`+ width: 500px;`
`136`	`132`	`}`
`137`		`-`
`138`		`-`
`139`		`-.dialogControl {`
`140`		`- margin: 0 20px 30px 0;`
`141`		`-}`
`142`		`-`
`143`	`133`	`.arduino-boards-toolbar-item-container {`
`144`	`134`	`margin-left: 3px;`
`145`	`135`	`}`

`‎arduino-ide-extension/src/electron-main/theia/electron-main-application.ts‎`

Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -82,16 +82,6 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {`
`82`	`82`	`return electronWindow;`
`83`	`83`	`}`
`84`	`84`
`85`		`- protected async getDefaultBrowserWindowOptions(): Promise<TheiaBrowserWindowOptions> {`
`86`		`- const options = await super.getDefaultBrowserWindowOptions();`
`87`		`- return {`
`88`		`- ...options,`
`89`		`- // Set and use a custom minimum window size: https://github.com/arduino/arduino-pro-ide/issues/337#issuecomment-687017281`
`90`		`- minWidth: 900,`
`91`		`- minHeight: 800`
`92`		`- };`
`93`		`- }`
`94`		`-`
`95`	`85`	`protected async startBackend(): Promise<number> {`
`96`	`86`	`// Check if we should run everything as one process.`
`97`	`87`	`const noBackendFork = process.argv.indexOf('--no-cluster') !== -1;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 5e6725d

File tree

3 files changed

3 files changed

`‎arduino-ide-extension/src/browser/boards/boards-config-dialog.ts‎`

`‎arduino-ide-extension/src/browser/style/boards-config-dialog.css‎`

`‎arduino-ide-extension/src/electron-main/theia/electron-main-application.ts‎`

0 commit comments