Commit 5897f37

author

Alberto Iannaccone

authored

fix url to open sketch in cloud editor (#452)

1 parent d790266 commit 5897f37Copy full SHA for 5897f37

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ export class CloudSketchbookContribution extends Contribution {`
`176`	`176`	`registry.registerCommand(CloudSketchbookCommands.OPEN_IN_CLOUD_EDITOR, {`
`177`	`177`	`execute: (arg) => {`
`178`	`178`	`this.windowService.openNewWindow(`
`179`		- `https://create.arduino.cc/editor/${arg.node.sketchId}`,
	`179`	+ `https://create.arduino.cc/editor/${arg.username}/${arg.node.sketchId}`,
`180`	`180`	`{ external: true }`
`181`	`181`	`);`
`182`	`182`	`},`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,9 @@ export class CloudSketchbookTreeWidget extends SketchbookTreeWidget {`
`94`	`94`	`this.currentSketchUri === node.uri.toString())`
`95`	`95`	`) {`
`96`	`96`	`return Array.from(new Set(node.commands)).map((command) =>`
`97`		`- this.renderInlineCommand(command.id, node)`
	`97`	`+ this.renderInlineCommand(command.id, node, {`
	`98`	`+ username: this.authenticationService.session?.account?.label,`
	`99`	`+ })`
`98`	`100`	`);`
`99`	`101`	`}`
`100`	`102`	`return undefined;`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,11 +125,12 @@ export class SketchbookTreeWidget extends FileTreeWidget {`
`125`	`125`
`126`	`126`	`protected renderInlineCommand(`
`127`	`127`	`commandId: string,`
`128`		`- node: SketchbookTree.SketchDirNode`
	`128`	`+ node: SketchbookTree.SketchDirNode,`
	`129`	`+ options?: any`
`129`	`130`	`): React.ReactNode {`
`130`	`131`	`const command = this.commandRegistry.getCommand(commandId);`
`131`	`132`	`const icon = command?.iconClass;`
`132`		`- const args = { model: this.model, node: node };`
	`133`	`+ const args = { model: this.model, node: node, ...options };`
`133`	`134`	`if (`
`134`	`135`	`command &&`
`135`	`136`	`icon &&`

Comments

(0)