Commit 24dc0bb

Akos Kittakittaakos

Akos Kitta

authored and

committed

fix: update monitor output after widget show

Closes #1724 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>

1 parent fa9777e commit 24dc0bbCopy full SHA for 24dc0bb

File tree

+12

-9

lines changed

arduino-ide-extension/src/browser/serial/monitor
- monitor-widget.tsx
- serial-monitor-send-output.tsx

+12

-9

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,11 @@ export class MonitorWidget extends ReactWidget {`
`117`	`117`	`(this.focusNode \|\| this.node).focus();`
`118`	`118`	`}`
`119`	`119`
	`120`	`+ protected override onAfterShow(msg: Message): void {`
	`121`	`+ super.onAfterShow(msg);`
	`122`	`+ this.update();`
	`123`	`+ }`
	`124`	`+`
`120`	`125`	`protected onFocusResolved = (element: HTMLElement \| undefined) => {`
`121`	`126`	`if (this.closing \|\| !this.isAttached) {`
`122`	`127`	`return;`

Lines changed: 7 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ export class SerialMonitorOutput extends React.Component<`
`17`	`17`	`* Do not touch it. It is used to be able to "follow" the serial monitor log.`
`18`	`18`	`*/`
`19`	`19`	`protected toDisposeBeforeUnmount = new DisposableCollection();`
`20`		`- private listRef: React.RefObject<any>;`
	`20`	`+ private listRef: React.RefObject<List>;`
`21`	`21`
`22`	`22`	`constructor(props: Readonly<SerialMonitorOutput.Props>) {`
`23`	`23`	`super(props);`
`@@ -34,12 +34,10 @@ export class SerialMonitorOutput extends React.Component<`
`34`	`34`	`<List`
`35`	`35`	`className="serial-monitor-messages"`
`36`	`36`	`height={this.props.height}`
`37`		`- itemData={`
`38`		`- {`
`39`		`- lines: this.state.lines,`
`40`		`- timestamp: this.state.timestamp,`
`41`		`- } as any`
`42`		`- }`
	`37`	`+ itemData={{`
	`38`	`+ lines: this.state.lines,`
	`39`	`+ timestamp: this.state.timestamp,`
	`40`	`+ }}`
`43`	`41`	`itemCount={this.state.lines.length}`
`44`	`42`	`itemSize={18}`
`45`	`43`	`width={'100%'}`
`@@ -93,11 +91,11 @@ export class SerialMonitorOutput extends React.Component<`
`93`	`91`	`this.toDisposeBeforeUnmount.dispose();`
`94`	`92`	`}`
`95`	`93`
`96`		`- scrollToBottom = ((): void => {`
	`94`	`+ privatereadonlyscrollToBottom = () => {`
`97`	`95`	`if (this.listRef.current && this.props.monitorModel.autoscroll) {`
`98`	`96`	`this.listRef.current.scrollToItem(this.state.lines.length, 'end');`
`99`	`97`	`}`
`100`		`- }).bind(this);`
	`98`	`+ };`
`101`	`99`	`}`
`102`	`100`
`103`	`101`	`const _Row = ({`

Comments

(0)