Commit 5b2f729

committed

[BREAKING] Removed debugging_supported field from BoardDetails gRPC call (#2438)

* Removed debugging_supported field from BoardDetailsResponse * fix typo

1 parent 1d595cb commit 5b2f729Copy full SHA for 5b2f729

File tree

+180

-192

lines changed

+180

-192

lines changed

Lines changed: 1 addition & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func Details(ctx context.Context, req rpc.BoardDetailsRequest) (rpc.BoardDetai`
`39`	`39`	`return nil, &arduino.InvalidFQBNError{Cause: err}`
`40`	`40`	`}`
`41`	`41`
`42`		`- boardPackage, boardPlatform, board, boardProperties, boardRefPlatform, err := pme.ResolveFQBN(fqbn)`
	`42`	`+ boardPackage, boardPlatform, board, boardProperties, _, err := pme.ResolveFQBN(fqbn)`
`43`	`43`	`if err != nil {`
`44`	`44`	`return nil, &arduino.UnknownFQBNError{Cause: err}`
`45`	`45`	`}`
`@@ -64,13 +64,6 @@ func Details(ctx context.Context, req rpc.BoardDetailsRequest) (rpc.BoardDetai`
`64`	`64`	`details.BuildProperties, _ = utils.ExpandBuildProperties(details.BuildProperties)`
`65`	`65`	`}`
`66`	`66`
`67`		`- details.DebuggingSupported = boardProperties.ContainsKey("debug.executable") \|\|`
`68`		`- boardPlatform.Properties.ContainsKey("debug.executable") \|\|`
`69`		`- (boardRefPlatform != nil && boardRefPlatform.Properties.ContainsKey("debug.executable")) \|\|`
`70`		- // HOTFIX: Remove me when the `arduino:samd` core is updated
`71`		`- boardPlatform.String() == "arduino:samd@1.8.9" \|\|`
`72`		`- boardPlatform.String() == "arduino:samd@1.8.8"`
`73`		`-`
`74`	`67`	`details.Package = &rpc.Package{`
`75`	`68`	`Name: boardPackage.Name,`
`76`	`69`	`Maintainer: boardPackage.Maintainer,`

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,19 @@`
`2`	`2`
`3`	`3`	`Here you can find a list of migration guides to handle breaking changes between releases of the CLI.`
`4`	`4`
`5`		`-## v0.35.0`
	`5`	`+## 0.35.0`
	`6`	`+`
	`7`	+### `debugging_supported` field has been removed from gRPC `cc.arduino.cli.commands.v1.BoardDetails` and `board details` command in CLI
	`8`	`+`
	`9`	+The `debugging_supported` field has been removed, since the possibility to debug is determined by:
	`10`	`+`
	`11`	`+- the board selected`
	`12`	`+- the board option selected`
	`13`	`+- the programmer selected`
	`14`	`+`
	`15`	+the `board details` command has no sufficient information to determine it. If you need to determine if a specific
	`16`	`+selection of board + option + programmer supports debugging, use the gRPC call`
	`17`	+`cc.arduino.cli.commands.v1.GetDebugConfig`: if the call is successful, it means that the debugging is supported.
`6`	`18`
`7`	`19`	### CLI `debug --info` changed JSON output.
`8`	`20`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -138,9 +138,6 @@ func (dr detailsResult) String() string {`
`138`	`138`	`t.AddRow(tr("Board name:"), details.Name)`
`139`	`139`	`t.AddRow(tr("FQBN:"), details.Fqbn)`
`140`	`140`	`addIfNotEmpty(tr("Board version:"), details.Version)`
`141`		`- if details.GetDebuggingSupported() {`
`142`		`- t.AddRow(tr("Debugging supported:"), table.NewCell("✔", color.New(color.FgGreen)))`
`143`		`- }`
`144`	`141`
`145`	`142`	`if details.Official {`
`146`	`143`	`t.AddRow() // get some space from above`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -304,9 +304,8 @@ func TestBoardDetails(t *testing.T) {`
`304`	`304`	`_, _, err = cli.Run("core", "install", "arduino:samd@1.8.8")`
`305`	`305`	`require.NoError(t, err)`
`306`	`306`
`307`		`- stdout, _, err = cli.Run("board", "details", "-b", "arduino:samd:nano_33_iot", "--format", "json")`
	`307`	`+ _, _, err = cli.Run("board", "details", "-b", "arduino:samd:nano_33_iot", "--format", "json")`
`308`	`308`	`require.NoError(t, err)`
`309`		- requirejson.Contains(t, stdout, `{"debugging_supported": true}`)
`310`	`309`	`}`
`311`	`310`
`312`	`311`	`func TestBoardDetailsNoFlags(t *testing.T) {`

Comments

(0)