Commit 2b8d6d7

authored

Remove empty object from the output of grpc commands (#2057)

1 parent 3ac8320 commit 2b8d6d7Copy full SHA for 2b8d6d7

File tree

1 file changed

-28

lines changed

commands/daemon
- daemon.go

1 file changed

-28

lines changed

`‎commands/daemon/daemon.go‎`

Lines changed: 7 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -159,10 +159,7 @@ func (s ArduinoCoreServerImpl) UpdateLibrariesIndex(req rpc.UpdateLibrariesInd`
`159`	`159`	`err := commands.UpdateLibrariesIndex(stream.Context(), req,`
`160`	`160`	`func(p *rpc.DownloadProgress) { stream.Send(&rpc.UpdateLibrariesIndexResponse{DownloadProgress: p}) },`
`161`	`161`	`)`
`162`		`- if err != nil {`
`163`		`- return convertErrorToRPCStatus(err)`
`164`		`- }`
`165`		`- return stream.Send(&rpc.UpdateLibrariesIndexResponse{})`
	`162`	`+ return convertErrorToRPCStatus(err)`
`166`	`163`	`}`
`167`	`164`
`168`	`165`	`// Create FIXMEDOC`
`@@ -357,10 +354,7 @@ func (s ArduinoCoreServerImpl) LibraryInstall(req rpc.LibraryInstallRequest, s`
`357`	`354`	`func(p *rpc.DownloadProgress) { stream.Send(&rpc.LibraryInstallResponse{Progress: p}) },`
`358`	`355`	`func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryInstallResponse{TaskProgress: p}) },`
`359`	`356`	`)`
`360`		`- if err != nil {`
`361`		`- return convertErrorToRPCStatus(err)`
`362`		`- }`
`363`		`- return stream.Send(&rpc.LibraryInstallResponse{})`
	`357`	`+ return convertErrorToRPCStatus(err)`
`364`	`358`	`}`
`365`	`359`
`366`	`360`	`// LibraryUpgrade FIXMEDOC`
`@@ -370,21 +364,15 @@ func (s ArduinoCoreServerImpl) LibraryUpgrade(req rpc.LibraryUpgradeRequest, s`
`370`	`364`	`func(p *rpc.DownloadProgress) { stream.Send(&rpc.LibraryUpgradeResponse{Progress: p}) },`
`371`	`365`	`func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryUpgradeResponse{TaskProgress: p}) },`
`372`	`366`	`)`
`373`		`- if err != nil {`
`374`		`- return convertErrorToRPCStatus(err)`
`375`		`- }`
`376`		`- return stream.Send(&rpc.LibraryUpgradeResponse{})`
	`367`	`+ return convertErrorToRPCStatus(err)`
`377`	`368`	`}`
`378`	`369`
`379`	`370`	`// LibraryUninstall FIXMEDOC`
`380`	`371`	`func (s ArduinoCoreServerImpl) LibraryUninstall(req rpc.LibraryUninstallRequest, stream rpc.ArduinoCoreService_LibraryUninstallServer) error {`
`381`	`372`	`err := lib.LibraryUninstall(stream.Context(), req,`
`382`	`373`	`func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryUninstallResponse{TaskProgress: p}) },`
`383`	`374`	`)`
`384`		`- if err != nil {`
`385`		`- return convertErrorToRPCStatus(err)`
`386`		`- }`
`387`		`- return stream.Send(&rpc.LibraryUninstallResponse{})`
	`375`	`+ return convertErrorToRPCStatus(err)`
`388`	`376`	`}`
`389`	`377`
`390`	`378`	`// LibraryUpgradeAll FIXMEDOC`
`@@ -393,10 +381,7 @@ func (s ArduinoCoreServerImpl) LibraryUpgradeAll(req rpc.LibraryUpgradeAllRequ`
`393`	`381`	`func(p *rpc.DownloadProgress) { stream.Send(&rpc.LibraryUpgradeAllResponse{Progress: p}) },`
`394`	`382`	`func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryUpgradeAllResponse{TaskProgress: p}) },`
`395`	`383`	`)`
`396`		`- if err != nil {`
`397`		`- return convertErrorToRPCStatus(err)`
`398`		`- }`
`399`		`- return stream.Send(&rpc.LibraryUpgradeAllResponse{})`
	`384`	`+ return convertErrorToRPCStatus(err)`
`400`	`385`	`}`
`401`	`386`
`402`	`387`	`// LibraryResolveDependencies FIXMEDOC`
`@@ -429,10 +414,7 @@ func (s ArduinoCoreServerImpl) ZipLibraryInstall(req rpc.ZipLibraryInstallRequ`
`429`	`414`	`stream.Context(), req,`
`430`	`415`	`func(p *rpc.TaskProgress) { stream.Send(&rpc.ZipLibraryInstallResponse{TaskProgress: p}) },`
`431`	`416`	`)`
`432`		`- if err != nil {`
`433`		`- return convertErrorToRPCStatus(err)`
`434`		`- }`
`435`		`- return stream.Send(&rpc.ZipLibraryInstallResponse{})`
	`417`	`+ return convertErrorToRPCStatus(err)`
`436`	`418`	`}`
`437`	`419`
`438`	`420`	`// GitLibraryInstall FIXMEDOC`
`@@ -441,10 +423,7 @@ func (s ArduinoCoreServerImpl) GitLibraryInstall(req rpc.GitLibraryInstallRequ`
`441`	`423`	`stream.Context(), req,`
`442`	`424`	`func(p *rpc.TaskProgress) { stream.Send(&rpc.GitLibraryInstallResponse{TaskProgress: p}) },`
`443`	`425`	`)`
`444`		`- if err != nil {`
`445`		`- return convertErrorToRPCStatus(err)`
`446`		`- }`
`447`		`- return stream.Send(&rpc.GitLibraryInstallResponse{})`
	`426`	`+ return convertErrorToRPCStatus(err)`
`448`	`427`	`}`
`449`	`428`
`450`	`429`	`// EnumerateMonitorPortSettings FIXMEDOC`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 2b8d6d7

File tree

1 file changed

1 file changed

`‎commands/daemon/daemon.go‎`

0 commit comments