Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 26ec573

Browse files
committed
Feat: Remove the most risky fixers from the next version (will be readded in the next release)
1 parent 8e9163c commit 26ec573

File tree

3 files changed

+5
-34
lines changed

3 files changed

+5
-34
lines changed

‎ecs.php‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,6 @@
6969
use PhpCsFixer\Fixer\FunctionNotation\LambdaNotUsedImportFixer;
7070
use PhpCsFixer\Fixer\FunctionNotation\NoUnreachableDefaultArgumentValueFixer;
7171
use PhpCsFixer\Fixer\FunctionNotation\NoUselessSprintfFixer;
72-
use PhpCsFixer\Fixer\FunctionNotation\PhpdocToParamTypeFixer;
73-
use PhpCsFixer\Fixer\FunctionNotation\PhpdocToPropertyTypeFixer;
74-
use PhpCsFixer\Fixer\FunctionNotation\PhpdocToReturnTypeFixer;
7572
use PhpCsFixer\Fixer\FunctionNotation\ReturnTypeDeclarationFixer;
7673
use PhpCsFixer\Fixer\FunctionNotation\VoidReturnFixer;
7774
use PhpCsFixer\Fixer\Import\NoLeadingImportSlashFixer;
@@ -133,14 +130,10 @@
133130
use PhpCsFixer\Fixer\Whitespace\NoExtraBlankLinesFixer;
134131
use PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer;
135132
use PhpCsFixer\Fixer\Whitespace\TypeDeclarationSpacesFixer;
136-
use SlevomatCodingStandard\Sniffs\Classes\RequireConstructorPropertyPromotionSniff;
137133
use SlevomatCodingStandard\Sniffs\ControlStructures\RequireNullSafeObjectOperatorSniff;
138134
use SlevomatCodingStandard\Sniffs\Exceptions\ReferenceThrowableOnlySniff;
139135
use SlevomatCodingStandard\Sniffs\Functions\RequireTrailingCommaInCallSniff;
140136
use SlevomatCodingStandard\Sniffs\Functions\RequireTrailingCommaInDeclarationSniff;
141-
use SlevomatCodingStandard\Sniffs\TypeHints\ParameterTypeHintSniff;
142-
use SlevomatCodingStandard\Sniffs\TypeHints\PropertyTypeHintSniff;
143-
use SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSniff;
144137
use SlevomatCodingStandard\Sniffs\TypeHints\UnionTypeHintFormatSniff;
145138
use Symplify\CodingStandard\Fixer\Commenting\ParamReturnAndVarTagMalformsFixer;
146139
use Symplify\EasyCodingStandard\Config\ECSConfig;
@@ -377,26 +370,13 @@
377370
ReferenceThrowableOnlySniff::class,
378371
// The @param, @return, @var and inline @var annotations should keep standard format
379372
ParamReturnAndVarTagMalformsFixer::class,
380-
// Takes `@var` annotation of non-mixed types and adjusts accordingly the property signature.
381-
PhpdocToPropertyTypeFixer::class,
382-
// Takes `@param` annotations of non-mixed types and adjusts accordingly the function signature.
383-
PhpdocToParamTypeFixer::class,
384-
// Takes `@return` annotation of non-mixed types and adjusts accordingly the function signature.
385-
PhpdocToReturnTypeFixer::class,
386-
// Promote constructor properties
387-
// @see https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5956
388-
RequireConstructorPropertyPromotionSniff::class,
389373

390374
// switch -> match
391375
// @see https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5894
392376

393377
// Require \Stringable interface in classes implementing __toString() method
394378
// > it may probably be a phpstan rule, more than cs rule - since it needs a class hierarchy to solve this
395379
// @see https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6235
396-
PropertyTypeHintSniff::class,
397-
398-
ParameterTypeHintSniff::class,
399-
ReturnTypeHintSniff::class,
400380

401381
// Multi-line arguments list in function/method declaration must have a trailing comma
402382
RequireTrailingCommaInDeclarationSniff::class,
@@ -531,18 +511,6 @@
531511
// Allow single line closures
532512
ScopeClosingBraceSniff::class . '.ContentBefore' => null,
533513

534-
// Skip unwanted rules from PropertyTypeHintSniff
535-
PropertyTypeHintSniff::class . '.' . PropertyTypeHintSniff::CODE_MISSING_TRAVERSABLE_TYPE_HINT_SPECIFICATION => null,
536-
PropertyTypeHintSniff::class . '.' . PropertyTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT => null,
537-
538-
// Skip unwanted rules from ParameterTypeHintSniff
539-
ParameterTypeHintSniff::class . '.' . ParameterTypeHintSniff::CODE_MISSING_TRAVERSABLE_TYPE_HINT_SPECIFICATION => null,
540-
ParameterTypeHintSniff::class . '.' . ParameterTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT => null,
541-
542-
// Skip unwanted rules from ReturnTypeHintSniff
543-
ReturnTypeHintSniff::class . '.' . ReturnTypeHintSniff::CODE_MISSING_TRAVERSABLE_TYPE_HINT_SPECIFICATION => null,
544-
ReturnTypeHintSniff::class . '.' . ReturnTypeHintSniff::CODE_MISSING_ANY_TYPE_HINT => null,
545-
546514
// We use declare(strict_types=1); after opening tag
547515
BlankLineAfterOpeningTagFixer::class => null,
548516
]);

‎tests/Integration/Fixtures/NewPhpFeatures.correct.php.inc‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,11 @@ namespace Lmc\CodingStandard\Integration\Fixtures;
44

55
class NewPhpFeatures
66
{
7-
public function __construct(private string $someString) // RequireConstructorPropertyPromotionSniff
7+
private string $someString;
8+
9+
public function __construct(string $someString)
810
{
11+
$this->someString = $someString;
912
}
1013

1114
public function php80features(

‎tests/Integration/Fixtures/NewPhpFeatures.wrong.php.inc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class NewPhpFeatures
66
{
77
private string $someString;
88

9-
public function __construct(string $someString)// RequireConstructorPropertyPromotionSniff
9+
public function __construct(string $someString)
1010
{
1111
$this->someString = $someString;
1212
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /