This repository was archived by the owner on May 14, 2020. It is now read-only.

Commit 906cb65

snotrzalmoxisus

snotr

authored and

committed

Fix function object’s prototype with toStringTag. (#85)

* Fix function object’s prototype with toStringTag. Some projects is implementing objects overriding .prototype[Symbol.toStringTag] for better read in .toString output and emulate something fancy like a type system in javascript. Unfortunately, it'll crash this project since it treat non recognized types as "Custom" and current representation is JsonValue. My patch just check for this case and use object representation instead. * Revert and move convertCustomType to objType

1 parent 8025cb4 commit 906cb65Copy full SHA for 906cb65

File tree

2 files changed

+12

-0

lines changed

examples/src
- App.js
src
- objType.js

2 files changed

+12

-0

lines changed

`‎examples/src/App.js‎`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,9 @@ const getValueLabelStyle = ({ style }, nodeType, keyPath) => ({`
`38`	`38`	`const longString =`
`39`	`39`	`'Loremipsumdolorsitamet,consecteturadipiscingelit.Namtempusipsumutfelisdignissimauctor.Maecenasodiolectus,finibusegetultricesvel,aliquamutelit.Loremipsumdolorsitamet,consecteturadipiscingelit.Namtempusipsumutfelisdignissimauctor.Maecenasodiolectus,finibusegetultricesvel,aliquamutelit.Loremipsumdolorsitamet,consecteturadipiscingelit.Namtempusipsumutfelisdignissimauctor.Maecenasodiolectus,finibusegetultricesvel,aliquamutelit.';`
`40`	`40`
	`41`	`+var Custom = function(value) { this.value = value; };`
	`42`	`+Custom.prototype[Symbol.toStringTag] = 'Custom';`
	`43`	`+`
`41`	`44`	`const data = {`
`42`	`45`	`array: [1, 2, 3],`
`43`	`46`	`emptyArray: [],`
`@@ -83,6 +86,10 @@ const data = {`
`83`	`86`	`{ objectKey: 'value2' }`
`84`	`87`	`]),`
`85`	`88`	hugeArray: Array.from({ length: 10000 }).map((_, i) => `item #${i}`),
	`89`	`+ customProfile: {`
	`90`	`+ avatar: new Custom('placehold.it/50x50'),`
	`91`	`+ name: new Custom('Name'),`
	`92`	`+ },`
`86`	`93`	`longString`
`87`	`94`	`};`
`88`	`95`

`‎src/objType.js‎`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,10 @@ export default function objType(obj) {`
`4`	`4`	`return 'Iterable';`
`5`	`5`	`}`
`6`	`6`
	`7`	`+ if (type === 'Custom' && obj.constructor !== Object && obj instanceof Object) {`
	`8`	+ // For projects implementing objects overriding `.prototype[Symbol.toStringTag]`
	`9`	`+ return 'Object';`
	`10`	`+ }`
	`11`	`+`
`7`	`12`	`return type;`
`8`	`13`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 906cb65

File tree

2 files changed

2 files changed

`‎examples/src/App.js‎`

`‎src/objType.js‎`

0 commit comments