Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 0d8cf3c

Browse files
author
Adrian Hurtado
committed
feat: add max and min to increment and decrement functions
1 parent 8b83c7f commit 0d8cf3c

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

‎src/valueFunctions/valueFunctions.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ export default {
1010
toggle: (bool) => !bool,
1111
},
1212
number: {
13-
increment: (num, delta)=>num+(typeofdelta==='number' ? delta : 1),
14-
decrement: (num, delta)=>num-(typeofdelta==='number' ? delta : 1),
13+
increment: (num, delta=1,max=Infinity)=>Math.min(max,num+delta),
14+
decrement: (num, delta=1,min=-Infinity)=>Math.max(min,num-delta),
1515
},
1616
string: {
1717
append: (string, str) => string + str,

‎src/valueFunctions/valueFunctions.spec.js‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,20 @@ describe('valueFunctions', () => {
1414
const shouldBe2 = ValueFunctions.number.increment(num)
1515
expect(shouldBe2).toBe(2)
1616
expect(shouldBe2).not.toBe(num)
17-
expect(ValueFunctions.number.increment(num, 2)).toBe(3)
18-
expect(ValueFunctions.number.increment(num, -2)).toBe(-1)
17+
expect(ValueFunctions.number.increment(num, 10)).toBe(11)
18+
expect(ValueFunctions.number.increment(num, -10)).toBe(-9)
19+
expect(ValueFunctions.number.increment(num, 10, 5)).toBe(5)
20+
expect(ValueFunctions.number.increment(num, -10, 0)).toBe(-9)
1921
})
2022
it('number.decrement', () => {
2123
const num = 1
2224
const shouldBe0 = ValueFunctions.number.decrement(num)
2325
expect(shouldBe0).toBe(0)
2426
expect(shouldBe0).not.toBe(num)
25-
expect(ValueFunctions.number.decrement(num, 2)).toBe(-1)
26-
expect(ValueFunctions.number.decrement(num, -2)).toBe(3)
27+
expect(ValueFunctions.number.decrement(num, 10)).toBe(-9)
28+
expect(ValueFunctions.number.decrement(num, -10)).toBe(11)
29+
expect(ValueFunctions.number.decrement(num, 10, 0)).toBe(0)
30+
expect(ValueFunctions.number.decrement(num, -10, 0)).toBe(11)
2731
})
2832

2933
it('string.append', () => {

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /