Commit 27282b4

committed

Fixed the existing instance being deleted in Awake

Replaced `else` with `else if (instance != this)` as a condition for the instance to be deleted in Awake. This fixes a really weird bug where if singleton was used in the editor and then again in play mode, it would delete the original instance and create a new one. Closes #21

1 parent 9416bf6 commit 27282b4Copy full SHA for 27282b4

File tree

1 file changed

-2

lines changed

Runtime/Scripts
- MonoSingleton.cs

1 file changed

-2

lines changed

`‎Runtime/Scripts/MonoSingleton.cs‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ protected virtual void Awake()`
`72`	`72`	`// Initialize existing instance`
`73`	`73`	`InitializeSingleton();`
`74`	`74`	`}`
`75`		`- else`
	`75`	`+ elseif(instance!=this)`
`76`	`76`	`{`
`77`	`77`
`78`	`78`	`// Destory duplicates`
`@@ -147,4 +147,4 @@ public static void DestroyInstance()`
`147`	`147`
`148`	`148`	`#endregion`
`149`	`149`	`}`
`150`		`-}`
	`150`	`+}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 27282b4

File tree

1 file changed

1 file changed

`‎Runtime/Scripts/MonoSingleton.cs‎`

0 commit comments