Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Sep 7, 2022. It is now read-only.

Zxw/3d mac #318

Merged
zhuxingwei merged 25 commits into zxw/3d from zxw/3d_mac
May 6, 2022
Merged

Zxw/3d mac #318

zhuxingwei merged 25 commits into zxw/3d from zxw/3d_mac
May 6, 2022

Conversation

@zhuxingwei
Copy link
Contributor

@zhuxingwei zhuxingwei commented Apr 6, 2022
edited
Loading

In this PR we are trying to support OpenGL backend on Mac/iOS and external texture on it, mainly including the following changes:
(1) fix the C# side codes so that the UIWidgetsPanel can now handle both Metal and OpenGLCore/OpenGLES backends on Mac/iOS respectively via different C++ bindings.

(2) refine the UIWidgets engine codes on the C++ side to fix issues caused by OpenGL context switching: Specifically, since we have to deal with both the openGL context of UIWidgets engine itself and that of Unity engine, we need a more careful approach to guarantee that the two kinds of openGL context doesn't mess around with each other. This situation doesn't not happen for flutter.

(3) refine the UIWidgetsPanel as well as SurfaceManager codes on C++ side to support both Metal and OpenGLCore/OpenGLES backends

(4) add the support of external native texture for OpenGLCore/OpenGLES backends on Mac/iOS respectively

(5) update the build code a bit so that it now support building iOS plugin with Mac 12 SDK

In this PR, we also add support for linear colorspace support on all platforms.

zhuxingwei added 17 commits March 29, 2022 15:19
@zhuxingwei zhuxingwei changed the title (削除) 【WIP】Zxw/3d mac (削除ここまで) (追記) Zxw/3d mac (追記ここまで) Apr 14, 2022

static bool UIWidgetsDisabled;

void DisableUIWidgets() {
Copy link
Contributor

@guanghuispark guanghuispark Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that this log is wrong.

Copy link
Contributor Author

@zhuxingwei zhuxingwei Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which log ?

Copy link
Contributor

@guanghuispark guanghuispark Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug.Log("Please change graphic api for UIWidgets.\n" +
 "Metal for iOS and MacOS.\n" +
 "Direct3D11 for Windows\n" +
 "Vulkan for Android\n");

(not this pr's change)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@guanghuispark guanghuispark guanghuispark left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /