Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit b891fe6

Browse files
author
Loic Mohin
committed
fix rgb bug
1 parent 6bf6a99 commit b891fe6

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

‎inters/ray_plane.c‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/* By: TheTerror <jfaye@student.42lyon.fr> +#+ +:+ +#+ */
77
/* +#+#+#+#+#+ +#+ */
88
/* Created: 2023年08月23日 21:27:05 by TheTerror #+# #+# */
9-
/* Updated: 2024年01月31日 13:14:20 by lmohin ### ########.fr */
9+
/* Updated: 2024年01月31日 14:29:27 by lmohin ### ########.fr */
1010
/* */
1111
/* ************************************************************************** */
1212

@@ -35,7 +35,6 @@ t_bool ft_ray_inter_pl(t_ray *ray, t_pl *pl, int x)
3535
{
3636
if (ft_assess_color(ray, 0))
3737
{
38-
(void) x;
3938
ray->obj.type = 0;
4039
ray->obj.index = x;
4140
return (ray->color = ft_color(&pl->rgb), __TRUE);

‎lightning/lightning.c‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/* By: lmohin <marvin@42.fr> +#+ +:+ +#+ */
77
/* +#+#+#+#+#+ +#+ */
88
/* Created: 2024年01月31日 09:22:08 by lmohin #+# #+# */
9-
/* Updated: 2024年01月31日 13:45:49 by lmohin ### ########.fr */
9+
/* Updated: 2024年01月31日 14:30:37 by lmohin ### ########.fr */
1010
/* */
1111
/* ************************************************************************** */
1212

@@ -82,17 +82,17 @@ t_bool lightning(t_vars *v, int i, int j)
8282
// printf("%f - %f\n", stock, v->ray.dir.x * v->pl[x2]->normal.x + v->ray.dir.y * v->pl[x2]->normal.y + v->pl[x2]->normal.z * v->ray.dir.z);
8383
if (stock < 0)
8484
stock *= -1;
85-
stock /= light_ray.len;
85+
stock /= ft_sq(light_ray.len);
8686
if (stock > 1)
8787
stock = 1;
8888
color = 0;
8989
color2 = ft_color(&v->pl[x2]->rgb);
90-
color += ((color2 >> 16) & 0xFF) * stock * 0.8 + v->amb->rgb.r * 0.2;
90+
color += ((color2 >> 16) & 0xFF) * stock * v->light->ratio + v->amb->rgb.r * v->amb->ratio;
9191
color <<= 8;
9292
color2 = ft_color(&v->pl[x2]->rgb);
93-
color += ((color2 >> 8) & 0xFF) * stock * 0.8 + v->amb->rgb.r * 0.2;
93+
color += ((color2 >> 8) & 0xFF) * stock * v->light->ratio + v->amb->rgb.g * v->amb->ratio;
9494
color <<= 8;
95-
color += (ft_color(&v->pl[x2]->rgb) & 0xFF) * stock * 0.8 + v->amb->rgb.b * 0.2;
95+
color += (ft_color(&v->pl[x2]->rgb) & 0xFF) * stock * v->light->ratio + v->amb->rgb.b * v->amb->ratio;
9696
v->ray->color = color;
9797
}
9898
//
@@ -118,17 +118,17 @@ t_bool lightning(t_vars *v, int i, int j)
118118
}
119119
if (stock < 0)
120120
stock *= -1;
121-
stock /= light_ray.len;
121+
stock /= ft_sq(light_ray.len);
122122
if (stock > 1)
123123
stock = 1;
124124
color2 = ft_color(&v->sp[x2]->rgb);
125125
color = 0;
126-
color += ((color2 >> 16) & 0xff) * stock * 0.8 + v->amb->rgb.r * 0.2;
126+
color += ((color2 >> 16) & 0xFF) * stock * v->light->ratio + v->amb->rgb.r * v->amb->ratio;
127127
color2 = ft_color(&v->sp[x2]->rgb);
128128
color <<= 8;
129-
color += ((color2 >> 8) & 0xff) * stock * 0.8 + v->amb->rgb.g * 0.2;
129+
color += ((color2 >> 8) & 0xFF) * stock * v->light->ratio + v->amb->rgb.g * v->amb->ratio;
130130
color <<= 8;
131-
color += (ft_color(&v->sp[x2]->rgb) & 0xFF) * stock * 0.8 + v->amb->rgb.b * 0.2;
131+
color += (ft_color(&v->sp[x2]->rgb) & 0xFF) * stock * v->light->ratio + v->amb->rgb.b * v->amb->ratio;
132132
v->ray->color = color;
133133
}
134134
//

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /