-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
added frame example code for python #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added frame example code for python #2240
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
Here are some key observations to aid the review process:
Duplicate Python Tab
There appears to be a duplicate Python tab in the Japanese documentation. The same Python code example is included twice in the same section.
{{< tab header="Python" text=true >}}
{{< gh-codeblock path="examples/python/tests/interactions/test_frames.py#L49-L50" >}}
{{< /tab >}}PR Code Suggestions ✨
No code suggestions found for the PR.
@titusfortner / @AutomatedTester please kindly help - to understand why is this failing? Is it what I did or some other reason. Requesting review. Thanks.
@titusfortner / @AutomatedTester please kindly help - to understand why is this failing? Is it what I did or some other reason. Requesting review. Thanks.
The PR looks fine to me. I believe the selenium version wasn't updated so it is raising an error for BiDi.
website_and_docs/content/documentation/webdriver/interactions/frames.en.md
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/frames.en.md
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/frames.en.md
Show resolved
Hide resolved
The requirements.txt update to 4.30 is causing failures.
They originate from: tests/bidi/cdp/test_network.py
This file tries this import: from selenium.webdriver.common.devtools.v131.network import Headers
devtools.v131 no longer exists in version 4.30, so the import fails. I tried changing to v132 and v134 and that resolves the import error, but the tests still fail for another reason. I'm not really sure what's going on at this point.
Thanks @cgoldberg
So should I wait for update before this can be squashed and merged .
Thank you for helping , I will wait for your answer.
@pallavigitwork I just replied in slack :)
You can revert the version back to 4.29.0 so tests pass and you can get this merged. Then open a new issue about the version upgrade to 4.30 and it can be tracked separately.
Let's just keep it here Corey.
As said on slack i saw GH later.
Limited access to internet and computer to look into this today.
I will do it tomorrow.
Thanks Corey for your help with review. @cgoldberg
@pallavigitwork OK... I think I have it all working. The fix was really simple. I created a PR into your repo. If you merge it into your branch, you will get my changes... then this PR should be in good shape.
As noted in my PR comments, there is still a failing test... but it also happens when using 4.29, so it shouldn't hold up your PR.
I was able to run the entire test suite locally with everything passing except this one test, and no more warnings.
Thank you Corey. I will take a look at it. Thank you for your kind help and time. @cgoldberg
534e226
into
SeleniumHQ:trunk
Thanks @Delta456 for your help.
Thank you @cgoldberg for your help.
Uh oh!
There was an error while loading. Please reload this page.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
added frame example code for python
Description
added frame example code for python
Motivation and Context
added frame example code for python
Types of changes
Checklist