Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Post for Multi-Arch Images via Docker Selenium #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 3 commits into SeleniumHQ:trunk from NDViet:trunk
May 24, 2024
Merged

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented May 23, 2024 •
edited
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation

Description

  • Added a new blog post titled "Multi-Arch Images via Docker Selenium".
  • Announced the availability of Multi-Arch Images for Selenium Grid Server on the official Selenium Docker Hub registry.
  • Detailed the supported architectures and browser binaries for different platforms.
  • Provided insights on building, testing, and distributing multi-arch images using Bash scripts, Makefile, CircleCI, and Docker's experimental features.

Changes walkthrough 📝

Relevant files
Documentation
multi-arch-images-via-docker-selenium.md
New blog post on Multi-Arch Images for Selenium Grid Server

website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md

  • Added a new blog post announcing the availability of Multi-Arch Images
    for Selenium Grid Server.
  • Included details on supported architectures and browser binaries.
  • Provided instructions on building, testing, and distributing
    multi-arch images.
    • +92/-0

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented May 23, 2024 •
    edited
    Loading

    ✅ Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit e9c6288
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66504cab0caadc000805e56f
    😎 Deploy Preview https://deploy-preview-1736--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 2 labels May 23, 2024
    Copy link
    Contributor

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the PR is primarily a documentation update with a new blog post. The content is straightforward and doesn't involve complex code changes, making it relatively easy to review.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion Score
    Grammar
    Correct the grammar in the introductory sentence for better clarity

    The sentence "This blog post to announce the visibility of Multi-Arch Images for Selenium
    Grid Server on official Selenium Docker Hub registry." is grammatically incorrect. It
    should be rephrased for better clarity.

    website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [9] 

    -This blog post to announce the visibility of Multi-Arch Images for Selenium Grid Server on official Selenium Docker Hub registry.
+This blog post announces the availability of Multi-Arch Images for Selenium Grid Server on the official Selenium Docker Hub registry.
    Suggestion importance[1-10]: 8

    Why: The suggested correction improves the grammatical structure of the sentence, enhancing the clarity and professionalism of the blog post.

    		8
    Correct the grammar in the sentence describing experimental Docker container images

    The phrase "For experimental Docker container images, which is able to run on platforms
    such as the Apple M-series or Raspberry Pi," should be rephrased to "For experimental
    Docker container images that are able to run on platforms such as the Apple M-series or
    Raspberry Pi," for grammatical correctness.

    website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [17] 

    -For experimental Docker container images, which is able to run on platforms such as the Apple M-series or Raspberry Pi,
+For experimental Docker container images that are able to run on platforms such as the Apple M-series or Raspberry Pi,
    Suggestion importance[1-10]: 7

    Why: The suggestion correctly identifies and fixes a grammatical error, improving the readability of the sentence.

    		7
    Correct the grammar in the sentence about Firefox versions for ARM64 and AMD64

    The phrase "the Firefox version in ARM64 image will be different with the AMD64 until the
    stable release is available." should be rephrased to "the Firefox version in the ARM64
    image will be different from the AMD64 version until the stable release is available." for
    grammatical correctness.

    website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [57] 

    -The Firefox version in ARM64 image will be different with the AMD64 until the stable release is available.
+The Firefox version in the ARM64 image will be different from the AMD64 version until the stable release is available.
    Suggestion importance[1-10]: 7

    Why: The suggestion improves grammatical accuracy and clarity in describing the differences between Firefox versions on different architectures.

    		7
    Readability
    Rephrase the sentence for better readability and clarity

    The sentence "We also would like to share something that has been done to keep the
    multi-arch images can be built, tested, and distributed seamlessly." is awkwardly phrased.
    It should be rephrased for better readability.

    website_and_docs/content/blog/2024/multi-arch-images-via-docker-selenium.md [72] 

    -We also would like to share something that has been done to keep the multi-arch images can be built, tested, and distributed seamlessly.
+We would also like to share what has been done to ensure that the multi-arch images can be built, tested, and distributed seamlessly.
    Suggestion importance[1-10]: 7

    Why: The suggested rephrasing resolves an awkward sentence structure, making the information more accessible and easier to understand.

    		7

    @VietND96 VietND96 changed the title (削除) Post for Docker Selenium (削除ここまで) (追記) Post for Multi-Arch Images via Docker Selenium (追記ここまで) May 23, 2024 
    Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
    Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @VietND96!

    @diemol diemol merged commit f50ca21 into SeleniumHQ:trunk May 24, 2024
    selenium-ci added a commit that referenced this pull request May 24, 2024 
    * Post for Docker Selenium
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
* Correct the readability as suggestion
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
---------
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
[deploy site] f50ca21
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    2 participants

    AltStyle によって変換されたページ (->オリジナル) /