-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update on_test_automation.en.md #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A very small yet obvious grammatical fix to a sentence on this page.
CLA assistant check
All committers have signed the CLA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sidsiddiqi ,
Thanks for the PR.
Can you please update text for other translated pages too.
Thanks,
Harsha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sidsiddiqi could you please update the other language pages which are still using the English version?
Can I also do the missing changes? I checked out the patch-1 branch from @sidsiddiqi
How can I commit to this PR?
Hi @boris779,
This is a trivial change. We may need to give some more time for the author for the requested changes.
Thanks,
Harsha
I've compared the files, also the other languages (for on_test_automation.xx.md) are a kind of outdated, I already changed it. Give me a call if you want to merge that.
Yes @boris779 , You can create a PR referencing this PR and giving credits to the original author.
This will do i think.
Thanks,
Harsha
Raised a PR #178 which was forked from @sidsiddiqi
* Update on_test_automation.en.md A very small yet obvious grammatical fix to a sentence on this page. * Updated other languages to finish PR Co-authored-by: sidsiddiqi <2281928+sidsiddiqi@users.noreply.github.com> Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
A very small yet obvious grammatical fix to a sentence on this page.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist