-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Browser chrome binary java sample #1460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser chrome binary java sample #1460
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
CLA assistant check
All committers have signed the CLA.
The goal of putting these in the github repo is so that they will pass.
What we need to do is to get the binary installed somewhere (probably using DriverFinder class) and then reference that location in the code.
Hi @titusfortner I have added code to get the binary location at runtime and referenced that location in the code.
Hi @santoshhawle ,
- Can you add similar changes in other translated pages with are other than in English?
- can you work on resolving the conflicts too?
Thanks,
Sri
Thanks for this code, but I ended up adding it in all the languages a few weeks ago — https://github.com/SeleniumHQ/seleniumhq.github.io/blob/trunk/examples/java/src/test/java/dev/selenium/browsers/ChromeTest.java#L58-L65
Hi @santoshhawle ,
Thank you for looking into this and raising the PR!
Looks like the changes have landed with commit efe4c5a.
Thanks,
Sri
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Java sample code added in documentation & sample for chrome to Start browser in a specified location
Motivation and Context
Types of changes
Checklist