Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update remote_webdriver_client.en.md #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcus-rp wants to merge 1 commit into SeleniumHQ:master from marcus-rp:patch-3

Conversation

@marcus-rp
Copy link

@marcus-rp marcus-rp commented Dec 20, 2019 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

{{< / code-panel >}}
{{< code-panel language="kotlin" >}}
driver.setFileDetector(new LocalFileDetector())
driver.fileDetector = LocalFileDetector()
Copy link
Member

@harsha509 harsha509 Dec 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @marcus-rp,

Good catch.
Can you please update code for other translated pages too

Copy link
Author

@marcus-rp marcus-rp Dec 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do I do it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the same directory you can find more files with the same name but a different suffixes... Those are the translations. Please also change the code in those files.
Don’t forget to sign the CLA please.

harsha509 and marcus-rp reacted with thumbs up emoji
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marcus-rp, thank you for your PR. However please have a look at the previous comments and to our contribution guidelines.

marcus-rp reacted with thumbs up emoji
Copy link
Member

hi @marcus-rp ,

Thanks for providing the PR.

As the PR gone stale now, I've updated the sample code in PR #160

Copy link
Member

diemol commented Jan 8, 2020

Replaced by #160

@diemol diemol closed this Jan 8, 2020
diemol added a commit that referenced this pull request Jan 8, 2020 
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol requested changes

@harsha509 harsha509 harsha509 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /