-
Notifications
You must be signed in to change notification settings - Fork 240
Update to use OmniSharp 0.19.0 #1424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andyleejordan
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
March 12, 2021 23:45
338b1ed to
3194f8a
Compare
Working on getting this put together. FYI @rjmholt and @david-driscoll
@andyleejordan
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
3 times, most recently
from
March 13, 2021 02:54
48d2ceb to
bedcc39
Compare
The PSES tests don't pass, but it builds! The extension tests pass, I think.
@andyleejordan
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
6 times, most recently
from
March 17, 2021 21:25
8185019 to
c83f4aa
Compare
@andyleejordan
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
March 19, 2021 16:50
c83f4aa to
f5df46e
Compare
Bumps [OmniSharp.Extensions.LanguageServer](https://github.com/OmniSharp/csharp-language-server-protocol) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases) - [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml) - [Commits](OmniSharp/csharp-language-server-protocol@v0.18.3...v0.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [OmniSharp.Extensions.DebugAdapter.Client](https://github.com/OmniSharp/csharp-language-server-protocol) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases) - [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml) - [Commits](OmniSharp/csharp-language-server-protocol@v0.18.3...v0.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [OmniSharp.Extensions.LanguageClient](https://github.com/OmniSharp/csharp-language-server-protocol) from 0.18.3 to 0.19.0. - [Release notes](https://github.com/OmniSharp/csharp-language-server-protocol/releases) - [Changelog](https://github.com/OmniSharp/csharp-language-server-protocol/blob/master/GitReleaseManager.yaml) - [Commits](OmniSharp/csharp-language-server-protocol@v0.18.3...v0.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@andyleejordan
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
March 23, 2021 19:00
f5df46e to
ac9de93
Compare
...HandlerBase` Except for `TelemetryEventParams` changes, saving for later.
Which we need for `record`s, and OmniSharp forces us to use.
@andyleejordan
andyleejordan
force-pushed
the
andschwa/omnisharp-update
branch
from
March 25, 2021 21:06
ac9de93 to
3ae17e8
Compare
@andyleejordan
andyleejordan
added
Area-Language Server
Issue-Enhancement
A feature request (enhancement).
labels
Mar 25, 2021
This is ready @rjmholt!
rjmholt
rjmholt
approved these changes
Mar 26, 2021
Name = "Main Thread"
})
// TODO: This is an empty container of threads...do we need to make a thread?
Threads = new Container<System.Threading.Thread>()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was weird, but we already didn't really know what to do with it (see "What do I do with these?")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This updates our base dependency, OmniSharp, from 0.18.3 to 0.19.0, which included many API changes. The approach taken to reduce code was the replacement of interface-implementations with ABC derivations, providing a few things for free for each of the derived classes, and is more inline with the expectations of the library developers. There are a couple classes that implement multiple interfaces, and have been left TODO for a switch to an ABC implementation. Furthermore, the C# language specification needed to be updated because of OmniSharp's use of new language features (namely
records), and I found that our xUnit package was misaligned.