Commit ff9c25b

committed

renaming ShouldGenerateAlias to create CreateAlias

1 parent 2632099 commit ff9c25bCopy full SHA for ff9c25b

File tree

-3

lines changed

src/PowerShellEditorServices/Services/PowerShell
- Handlers
  - RenameSymbol.cs
- Refactoring
  - IterativeVariableVisitor.cs

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ namespace Microsoft.PowerShell.EditorServices.Handlers`
`17`	`17`	`internal interface IRenameSymbolHandler : IJsonRpcRequestHandler<RenameSymbolParams, RenameSymbolResult> { }`
`18`	`18`
`19`	`19`	`public class RenameSymbolOptions {`
`20`		`- public bool ShouldGenerateAlias { get; set; }`
	`20`	`+ public bool CreateAlias { get; set; }`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public class RenameSymbolParams : IRequest<RenameSymbolResult>`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public IterativeVariableRename(string NewName, int StartLineNumber, int StartCol`
`31`	`31`	`this.StartLineNumber = StartLineNumber;`
`32`	`32`	`this.StartColumnNumber = StartColumnNumber;`
`33`	`33`	`this.ScriptAst = ScriptAst;`
`34`		`- this.options = options ?? new RenameSymbolOptions { ShouldGenerateAlias = true };`
	`34`	`+ this.options = options ?? new RenameSymbolOptions { CreateAlias = true };`
`35`	`35`
`36`	`36`	`VariableExpressionAst Node = (VariableExpressionAst)GetVariableTopAssignment(StartLineNumber, StartColumnNumber, ScriptAst);`
`37`	`37`	`if (Node != null)`
`@@ -406,7 +406,7 @@ private void ProcessVariableExpressionAst(VariableExpressionAst variableExpressi`
`406`	`406`	`};`
`407`	`407`	`// If the variables parent is a parameterAst Add a modification`
`408`	`408`	`if (variableExpressionAst.Parent is ParameterAst paramAst && !AliasSet &&`
`409`		`- options.ShouldGenerateAlias)`
	`409`	`+ options.CreateAlias)`
`410`	`410`	`{`
`411`	`411`	`TextChange aliasChange = NewParameterAliasChange(variableExpressionAst, paramAst);`
`412`	`412`	`Modifications.Add(aliasChange);`

Comments

(0)