Commit 74ec4e9

committed

Convert PsesSignatureHelpHandler to inherit SignatureHelpHandlerBase

1 parent 51e6a25 commit 74ec4e9Copy full SHA for 74ec4e9

File tree

1 file changed

-17

lines changed

src/PowerShellEditorServices/Services/TextDocument/Handlers
- SignatureHelpHandler.cs

1 file changed

-17

lines changed

`‎src/PowerShellEditorServices/Services/TextDocument/Handlers/SignatureHelpHandler.cs‎`

Lines changed: 7 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,15 +17,13 @@`
`17`	`17`
`18`	`18`	`namespace Microsoft.PowerShell.EditorServices.Handlers`
`19`	`19`	`{`
`20`		`- internal class PsesSignatureHelpHandler : ISignatureHelpHandler`
	`20`	`+ internal class PsesSignatureHelpHandler : SignatureHelpHandlerBase`
`21`	`21`	`{`
`22`	`22`	`private readonly ILogger _logger;`
`23`	`23`	`private readonly SymbolsService _symbolsService;`
`24`	`24`	`private readonly WorkspaceService _workspaceService;`
`25`	`25`	`private readonly PowerShellContextService _powerShellContextService;`
`26`	`26`
`27`		`- private SignatureHelpCapability _capability;`
`28`		`-`
`29`	`27`	`public PsesSignatureHelpHandler(`
`30`	`28`	`ILoggerFactory factory,`
`31`	`29`	`SymbolsService symbolsService,`
`@@ -38,17 +36,14 @@ public PsesSignatureHelpHandler(`
`38`	`36`	`_powerShellContextService = powerShellContextService;`
`39`	`37`	`}`
`40`	`38`
`41`		`- publicSignatureHelpRegistrationOptions GetRegistrationOptions()`
	`39`	`+ protectedoverrideSignatureHelpRegistrationOptions CreateRegistrationOptions(SignatureHelpCapabilitycapability,ClientCapabilitiesclientCapabilities)=>newSignatureHelpRegistrationOptions`
`42`	`40`	`{`
`43`		`- return new SignatureHelpRegistrationOptions`
`44`		`- {`
`45`		`- DocumentSelector = LspUtils.PowerShellDocumentSelector,`
`46`		`- // A sane default of " ". We may be able to include others like "-".`
`47`		`- TriggerCharacters = new Container<string>(" ")`
`48`		`- };`
`49`		`- }`
	`41`	`+ DocumentSelector = LspUtils.PowerShellDocumentSelector,`
	`42`	`+ // A sane default of " ". We may be able to include others like "-".`
	`43`	`+ TriggerCharacters = new Container<string>(" ")`
	`44`	`+ };`
`50`	`45`
`51`		`- public async Task<SignatureHelp> Handle(SignatureHelpParams request, CancellationToken cancellationToken)`
	`46`	`+ public overrideasync Task<SignatureHelp> Handle(SignatureHelpParams request, CancellationToken cancellationToken)`
`52`	`47`	`{`
`53`	`48`	`if (cancellationToken.IsCancellationRequested)`
`54`	`49`	`{`
`@@ -95,11 +90,6 @@ await _symbolsService.FindParameterSetsInFileAsync(`
`95`	`90`	`};`
`96`	`91`	`}`
`97`	`92`
`98`		`- public void SetCapability(SignatureHelpCapability capability)`
`99`		`- {`
`100`		`- _capability = capability;`
`101`		`- }`
`102`		`-`
`103`	`93`	`private static ParameterInformation CreateParameterInfo(ParameterInfo parameterInfo)`
`104`	`94`	`{`
`105`	`95`	`return new ParameterInformation`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 74ec4e9

File tree

1 file changed

1 file changed

`‎src/PowerShellEditorServices/Services/TextDocument/Handlers/SignatureHelpHandler.cs‎`

0 commit comments