Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 4cf1387

Browse files
Merge pull request #1460 from PowerShell/andschwa/omnisharp
Bump OmniSharp package to `0.19.2-beta0001`
2 parents 7c035bc + 21c351b commit 4cf1387

File tree

5 files changed

+18
-9
lines changed

5 files changed

+18
-9
lines changed

‎src/PowerShellEditorServices/Extensions/Api/EditorExtensionServiceProvider.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
using Microsoft.PowerShell.EditorServices.Utility;
1212
using OmniSharp.Extensions.LanguageServer.Protocol.Server;
1313

14-
using Internal = Microsoft.PowerShell.EditorServices.Services;
14+
using InternalServices = Microsoft.PowerShell.EditorServices.Services;
1515

1616
namespace Microsoft.PowerShell.EditorServices.Extensions.Services
1717
{
@@ -46,7 +46,7 @@ internal EditorExtensionServiceProvider(IServiceProvider serviceProvider)
4646
LanguageServer = new LanguageServerService(_serviceProvider.GetService<ILanguageServerFacade>());
4747
//DocumentSymbols = new DocumentSymbolService(_serviceProvider.GetService<SymbolsService>());
4848
ExtensionCommands = new ExtensionCommandService(_serviceProvider.GetService<ExtensionService>());
49-
Workspace = new WorkspaceService(_serviceProvider.GetService<Internal.WorkspaceService>());
49+
Workspace = new WorkspaceService(_serviceProvider.GetService<InternalServices.WorkspaceService>());
5050
EditorContext = new EditorContextService(_serviceProvider.GetService<ILanguageServerFacade>());
5151
EditorUI = new EditorUIService(_serviceProvider.GetService<ILanguageServerFacade>());
5252
}

‎src/PowerShellEditorServices/PowerShellEditorServices.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
3030
<PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="5.0.0" />
3131
<PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
32-
<PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.0" />
33-
<PackageReference Include="OmniSharp.Extensions.DebugAdapter.Server" Version="0.19.0" />
32+
<PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.2-beta0001" />
33+
<PackageReference Include="OmniSharp.Extensions.DebugAdapter.Server" Version="0.19.2-beta0001" />
3434
<PackageReference Include="PowerShellStandard.Library" Version="5.1.1" />
3535
<PackageReference Include="Serilog" Version="2.10.0" />
3636
<PackageReference Include="Serilog.Extensions.Logging" Version="3.0.1" />

‎src/PowerShellEditorServices/Services/DebugAdapter/Handlers/ThreadsHandler.cs‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,26 @@
77
using System.Threading.Tasks;
88
using OmniSharp.Extensions.DebugAdapter.Protocol.Models;
99
using OmniSharp.Extensions.DebugAdapter.Protocol.Requests;
10+
using Thread = OmniSharp.Extensions.DebugAdapter.Protocol.Models.Thread;
1011

1112
namespace Microsoft.PowerShell.EditorServices.Handlers
1213
{
1314
internal class ThreadsHandler : IThreadsHandler
1415
{
16+
internal static Thread PipelineThread { get; } =
17+
new Thread { Id = 1, Name = "PowerShell Pipeline Thread" };
18+
1519
public Task<ThreadsResponse> Handle(ThreadsArguments request, CancellationToken cancellationToken)
1620
{
1721
return Task.FromResult(new ThreadsResponse
1822
{
19-
// TODO: This is an empty container of threads...do we need to make a thread?
20-
Threads = new Container<System.Threading.Thread>()
23+
// TODO: OmniSharp supports multithreaded debugging (where
24+
// multiple threads can be debugged at once), but we don't. This
25+
// means we always need to set AllThreadsStoppped and
26+
// AllThreadsContinued in our events. But if we one day support
27+
// multithreaded debugging, we'd need a way to associate
28+
// debugged runspaces with .NET threads in a consistent way.
29+
Threads = new Container<Thread>(PipelineThread)
2130
});
2231
}
2332
}

‎test/PowerShellEditorServices.Test.E2E/PowerShellEditorServices.Test.E2E.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
<PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
1111
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
1212
<PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
13-
<PackageReference Include="OmniSharp.Extensions.LanguageClient" Version="0.19.0" />
14-
<PackageReference Include="OmniSharp.Extensions.DebugAdapter.Client" Version="0.19.0" />
13+
<PackageReference Include="OmniSharp.Extensions.LanguageClient" Version="0.19.2-beta0001" />
14+
<PackageReference Include="OmniSharp.Extensions.DebugAdapter.Client" Version="0.19.2-beta0001" />
1515
<PackageReference Include="xunit" Version="2.4.1" />
1616
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
1717
<PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />

‎test/PowerShellEditorServices.Test/PowerShellEditorServices.Test.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<PackageReference Include="xunit" Version="2.4.1" />
2828
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.3" />
2929
<PackageReference Include="Xunit.SkippableFact" Version="1.4.13" />
30-
<PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.0" />
30+
<PackageReference Include="OmniSharp.Extensions.LanguageServer" Version="0.19.2-beta0001" />
3131
<DotNetCliToolReference Include="dotnet-xunit" Version="2.4.0-beta.1.build3958" />
3232
</ItemGroup>
3333
<ItemGroup>

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /