-
Notifications
You must be signed in to change notification settings - Fork 293
Combines mergedSchemas with original to ensure no edge properties are lost in schema item #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.9 kB (+0.05%) Total Size: 9.15 MB
i️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 1283280):
https://docusaurus-openapi-36b86--pr985-5uzhfb7f.web.app
(expires 2024年11月03日 15:31:57 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: bf293780ee827f578864d92193b8c2866acd459f
if (name === "eventName") {
console.log(mergedSchemaName, combinedSchemas);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this debugging info that was left in there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue reported in #977 and also adds support for rendering
examplevalue.Motivation and Context
Previously, if an edge property referenced an allOf the behavior was to resolve the allOf and render the
SchemaItembased solely on that result. This change now merges the allOf result with the original schema to ensure nothing is lost.How Has This Been Tested?
Tested by reproducing issue described in #977
Screenshots (if appropriate)
Screenshot 2024年10月04日 at 11 25 30 AM