You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feedback is encouraged. I had to make a few choices here and there and I'm unsure if they are the best.
Also, it seems like deployments are failing and I can't inspect or check details. @transitive-bullshit let me know if there is anything I can do to fix them.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced
LernaandYarnwithTurboandPnpm.Changes:
tsupand lesstsctsupis the recommended tool inturbodocstsup --watchreplaces all thewatchtasks. It automatically re-builds a package when in development tasks. Docstsupnow generates the type definitions with the configdts: trueontsup.config.tsDocscompositeis not supported bytsup, so I've changed it tofalseDTS error withcompositeegoist/tsup#571 .turbodocs"workspace:*". They should get replaced by the actual version when publishing Pnpm workspaces.turbotasks docsturbolinting docsturbo.json)package.jsonturbo.json.deploytask tovercel-deployin examples to avoid confusion withpnpm deploypnpm vercel-deployandpnpm run vercel-deployare valid from an example directorydeployname but that would only work withpnpm run deploybecausepnpm deployis an existent pnpm command.turbocaching.Benefits
This change has the following advantages:
devwith a single commandTurbo Examples
The configuration was inspired by Turborepo official examples
Basic example: https://github.com/vercel/turbo/tree/main/examples/basic
CRA example: https://github.com/vercel/turbo/tree/main/examples/with-create-react-app
Kitchen sink example; https://github.com/vercel/turbo/tree/main/examples/kitchen-sink
This bugfix was needed for a correct build of
notion-x-example-fullhandle possible NotionCompatAPI without search #459Tests
[x] Installing
[x] Running a global build:
[x] Running a build from the package dir
[x] Running every dev task
[x] Running tests execute
uniteslintandprettier.[x] Running dev in a single example, modifying a dependency, and verifying it rebuilds it
[x] Connecting with
nextjs-notion-starter-kit.yarnlink and the contributing docs from that repo are still valid after this change https://github.com/transitive-bullshit/nextjs-notion-starter-kit/blob/main/contributing.md[x] Running publish executed the correct tasks
[x] Running vercel deploy
[x] The cache works as expected in all tasks