Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit b4b5ef6

Browse files
authored
fix(forms): disable onTouch for date, number and selectedIndex value accessors (#986)
`touch` event is not suitable for triggering ngOnTouch classes for iOS and is causing several issues, such as overriding the change event. related #804 related #866 fixes #887 
1 parent 421978e commit b4b5ef6

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

‎nativescript-angular/value-accessors/date-value-accessor.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const DATE_VALUE_ACCESSOR = {
2525
"date-picker[ngModel],date-picker[formControlName],date-picker[formControl]",
2626
providers: [DATE_VALUE_ACCESSOR],
2727
host: {
28-
"(touch)": "onTouched()",
2928
"(dateChange)": "onChange($event.value)",
3029
},
3130
})

‎nativescript-angular/value-accessors/number-value-accessor.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ const NUMBER_VALUE_ACCESSOR = {
2424
"slider[ngModel],slider[formControlName],slider[formControl]",
2525
providers: [NUMBER_VALUE_ACCESSOR],
2626
host: {
27-
"(touch)": "onTouched()",
2827
"(valueChange)": "onChange($event.value)",
2928
},
3029
})

‎nativescript-angular/value-accessors/selectedIndex-value-accessor.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ export type SelectableView = {selectedIndex: number} & View;
3838
"tab-view[ngModel],tab-view[formControlName],tab-view[formControl]",
3939
providers: [SELECTED_INDEX_VALUE_ACCESSOR],
4040
host: {
41-
"(touch)": "onTouched()",
4241
"(selectedIndexChange)": "onChange($event.value)",
4342
},
4443
})

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /