Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use cmake-rn #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kraenhansen wants to merge 3 commits into NativeScript:main
base: main
Choose a base branch
Loading
from kraenhansen:cmake-rn
Draft

Use cmake-rn #22

kraenhansen wants to merge 3 commits into NativeScript:main from kraenhansen:cmake-rn

Conversation

@kraenhansen
Copy link

@kraenhansen kraenhansen commented Oct 24, 2025
edited
Loading

I wanted to show how I intended the React Native Node-API tooling to be used: cmake-rn taking control of the building of Apple frameworks and construction of the Xcframework.

It builds 🤷 But I haven't tried running it (because I don't know how to 🙈) and I am without a doubt missing context for what I'm suggesting here 😁 Feel free to pick whatever makes sense to the project (if any).

Arguably, you could also move the call to cmake-rn all the way out to the package.json as a package script, like we do in the host when building weak-node-api.

Note: This is currently missing linking with weak-node-api as per https://github.com/callstackincubator/react-native-node-api/tree/main/packages/cmake-rn#linking-against-node-api

# Defines the "weak-node-api" target
include(${WEAK_NODE_API_CONFIG})
target_link_libraries(addon PRIVATE weak-node-api)

☝️ is because callstackincubator/react-native-node-api#192 causing weak-node-api to miss an x86_64 slice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /